Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: evaluation v2 #41

Merged
merged 13 commits into from
Dec 1, 2023
Merged

feat: evaluation v2 #41

merged 13 commits into from
Dec 1, 2023

Conversation

bgiori
Copy link
Collaborator

@bgiori bgiori commented Nov 17, 2023

Summary

Implement Evaluation V2

  • New evaluation binary with updated interface.
  • New /v2/vardata and /v2/flags apis for remote and local evaluation
  • Additional info sent in Assignment event.
  • New evaluate_v2 and fetch_v2 methods for consuming v2 results.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@bgiori bgiori requested a review from tyiuhc November 17, 2023 01:31
@tyiuhc
Copy link
Collaborator

tyiuhc commented Nov 17, 2023 •
edited
Loading

nit: there seems to be an error in the remote fetch_async_with_retry test case - TypeError: callback_for_async() takes 3 positional arguments but 4 were given

@tyiuhc tyiuhc mentioned this pull request Nov 22, 2023
Merged
1 task
@bgiori bgiori requested a review from tyiuhc November 22, 2023 21:32
@bgiori bgiori merged commit 8a57489 into main Dec 1, 2023
3 checks passed
@bgiori bgiori deleted the evaluation-v2 branch December 1, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyiuhc tyiuhc tyiuhc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgiori @tyiuhc