Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected lines in Download/Shared lists become illegible when losing focus #385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danim7
Copy link

@danim7 danim7 commented Dec 10, 2024

In several lists across amule, a selected line that loses focus becomes illegible because it is drawn with a white text on a white background.

There are a couple of ways to reproduce it: It happens when right-clicking on a line in the list. It also happens when selecting a line in the downloads/shared list (upper side of the window), and then clicking a line in the secondary list about clients (bottom side of the window).

The affected windows are: Downloads and Shared.
The Search window is not affected by this issue.
When comparing them, all of them use the same colour scheme, but the affected classes are using a Blend() on the colours, while the unaffected class isn't. The proposed change is to remove the Blend() on the colours from the affected classes.

Attaching a couple of screenshots before and after the fix.

The test environment has been Ubuntu 24.04, compiling the last version from master with wxWidgets 3.2.4 and boost 1.83.

Before: the third line is selected in the upper list, but when clicking on a peer in the bottom list, the line becomes illegible:

before_fix

After: a line is selected in the upper list, and when clicking on a peer in the bottom list, the line can still be read:

after_fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant