Skip to content

feat: bad examples demo #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andre-3rd-Viking wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: bad examples demo #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions coding-guide-helper/src/anti-patterns-examples.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// This code uses multiple comparisons in a single if statement
export const antiPatternExample_01 = (value: string) => {
if (value === 'a' || value === 'b' || value === 'c') {
Copy link
Collaborator

@VikingLichens VikingLichens Dec 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

console.log('Value is a, b, or c')
} else {
console.log('Value is something else')
}
}

// This code should use Array.some() for a more readable and concise solution
export const antiPatternExample_02 = (value: string) => {
const items = [
{ id: 1, name: 'Alice', isActive: false },
{ id: 2, name: 'Bob', isActive: false },
{ id: 3, name: 'Charlie', isActive: true },
]

const activeItems = items.find((item) => item.isActive) !== undefined
console.info('====>>> info', activeItems)
}