enable user configuration of curl options connecttimeout and timeout #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The values of these new keys are set to the defaults of curl. Now the user can also change these two values for their requirements. When server errors occur on amazons side (which can happen, as on dec 7th) you can now configure to just let the user wait for example 60s before it times out instead of 300s on each request/process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The values of these new keys are set to the defaults of curl.
Now the user can also change these two values for their requirements.
When server errors occur on amazons side (which can happen, as on dec 7th) you
can now configure to just let the user wait for example 60s before it times out
instead of 300s on each request/process.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.