[AENT-7570]/client side fixes #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandhujasmine
commented
Sep 9, 2024
| '_revision': ident['_revision'], | ||
| '_record_type': 'project', | ||
| } | ||
| rrec = self._revision(dep2proj) |
There was a problem hiding this comment.
wanted to use the existing _revision code to raise an error if the revision is not found. It would be nice if it would list the available revisions but didn't try to figure that out.
sandhujasmine
commented
Sep 9, 2024
| @@ -1551,7 +1551,19 @@ def deployment_open(self, ident, frame=False, format=None): | |||
|
|
|||
| def deployment_patch(self, ident, format=None, **kwargs): | |||
| drec = self._ident_record("deployment", ident) | |||
| data = {k: v for k, v in kwargs.items() if v is not None} | |||
| data = {k: v for k, v in kwargs.items() if v is not None and v != drec[k]} | |||
There was a problem hiding this comment.
Added the check that if the value in kwargs isn't different from existing deployment attribute, then don't bother calling the API (see this: v != drec[k]). This isn't necessary since the operations are idempotent; but it seemed easy enough to add so I did. I don't know if the server side already takes care of this.
mcg1969
approved these changes
Sep 10, 2024
|
@sandhujasmine this is working great! I was able to verify that this successfully results in an update to our database as well as to the deployment itself. |
joshburt
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to patch resource-profile; and the deployed-version.
Testing
Ensure this is being tested against latest deployment of anaconda-platform master so it has this fix (https://github.com/anaconda/anaconda-platform/pull/6970) in.
Follow the same testing instructions on the server side as listed in this PR#6970 to start a deployment with version 0.1.0; then create an update and tag it as 0.1.1
Now use this updated client side ae5 version to apply the patches:
a2-eca80be7b7a143f78299bd615cf66ab5Watch the
anaconda-apppod get updated to the latest 0.1.1 deployment. You can verify in the UI; verify in the response printed by the client; you can also verify in the AE server UI.