projects: Add missing sysid IP #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIoandan
requested review from
AndrDragomir,
FilipG24,
acostina,
AndreiGrozav and
PopPaul2021
as code owners
IuliaCMoldovan
requested changes
Sep 11, 2023
There was a problem hiding this comment.
- Please update the description of the PR, and the commit body since it has a duplicate word
- Tick the checklist points that fit this PR
- Where the sysid IP was added, it would be better if it is like in PR Added logging of make params to the sysid memory #1038. Take as an example
projects/ad4630_fmc/zed/system_bd.tcl from that PR.
The parameters of these projects ad9209, ad9213_dual_ebz, and adrv9009 should be added
in the same manner (which havemakeparameters) - Makefiles should be regenerated, as they are still missing some edits
PIoandan
force-pushed
the
add_missing_sysid
branch
from
d890e33 to
7e24da3
Compare
* Added make parameters for the sysid ip for the projects: ad9209_fmca_ebz/vck190, ad9213_dual_ebz/s10soc and adrv9009/s10soc Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com>
PIoandan
force-pushed
the
add_missing_sysid
branch
from
7e24da3 to
ad596dd
Compare
PopPaul2021
requested changes
Oct 2, 2023
Added an empty line at the end of the adrv9009/s10soc/system_qsys.tcl file. Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com>
IuliaCMoldovan
approved these changes
Oct 24, 2023
acostina
approved these changes
Oct 27, 2023
AndreiGrozav
approved these changes
Nov 3, 2023
AndrDragomir
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The sysid IP was added in ad9209_fmca_ebz/vck190, ad9213_dual_ebz/s10soc and adrv9009/s10soc
PR Type
PR Checklist