FMC pinout configurations for AD4630. #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Villyam
requested review from
sarpadi,
PopPaul2021,
acostina and
AndreiGrozav
as code owners
|
|
PopPaul2021
requested changes
Oct 18, 2023
| D20 LA17_P_CC SCK_OUT_FMC ad463x_echo_sclk LVCMOS25 #N/A | ||
| C11 LA06_N SDI_FMC ad463x_spi_sdo LVCMOS25 #N/A | ||
| C22 LA18_P_CC BUSY_FMC ad463x_busy LVCMOS25 #N/A | ||
| C30 SCL SCL iic_scl LVCMOS33 #N/A |
There was a problem hiding this comment.
The SCL and SDA pins are already constrained in zed_system_constr.xdc . Can you please remove them from this file?
| set_property -dict {PACKAGE_PIN R7 IOSTANDARD LVCMOS33} [get_ports iic_scl] | ||
| set_property -dict {PACKAGE_PIN U7 IOSTANDARD LVCMOS33} [get_ports iic_sda] | ||
| set_property -dict {PACKAGE_PIN R7 IOSTANDARD LVCMOS33} [get_ports iic_scl] ; ## C30 FMC-SCL | ||
| set_property -dict {PACKAGE_PIN U7 IOSTANDARD LVCMOS33} [get_ports iic_sda] ; ## C31 FMC-SDA |
There was a problem hiding this comment.
From what I've seen we don't have I2C pins description on other carriers. We could drop these modifications for now and check if we need to update descriptions for all carriers.
PopPaul2021
approved these changes
Oct 18, 2023
Signed-off-by: Villyam <Vilmoscsaba.Jozsa@analog.com>
Signed-off-by: Villyam <Vilmoscsaba.Jozsa@analog.com>
Signed-off-by: Villyam <Vilmoscsaba.Jozsa@analog.com>
Signed-off-by: Villyam <Vilmoscsaba.Jozsa@analog.com>
Villyam
force-pushed
the
ad4630_fmc_txt
branch
from
e332f7c to
293cb45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
- projects/ad4630_fmc/zed/system_constr.xdc
- projects/ad4630_fmc/zed/system_constr_4sdi.xdc
PR Type
PR Checklist