Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing connections from spi on versal boards #1199

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

bluncan
Copy link
Contributor

@bluncan bluncan commented Oct 17, 2023

common: vmk180: Connected missing ss from spi
ad9081_fmca_ebz: vck190: system_top: Fixed spi signals indentation

PR Description

In Vivado 2023.1, the spi interface signals exposed by the versal_cips IP were changed and thus when building the hdl projects (for Versal boards) with the new Vivado version only slave select 0 was connected. This commit connects all 3 slave selects.

This breaks compatibility with Vivado 2022.2.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

FilipG24
FilipG24 previously approved these changes Oct 17, 2023
Copy link
Contributor

@FilipG24 FilipG24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

projects/common/vmk180/system_top.v Outdated Show resolved Hide resolved
projects/common/vmk180/system_top.v Outdated Show resolved Hide resolved
ad9081_fmca_ebz: vck190: system_top: Fixed spi signals indentation

Signed-off-by: Bogdan Luncan <bogdan.luncan@analog.com>
@bluncan
Copy link
Contributor Author

bluncan commented Oct 25, 2023

v2: Removed csn outputs from system_top.v on base designs

@bluncan bluncan merged commit b1002ca into master Oct 25, 2023
1 of 2 checks passed
@bluncan bluncan deleted the fix_versal_spi_ss branch October 25, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants