-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADI VNA 8 channels project #1236
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahitevrenkaya
requested review from
acostina,
AndreiGrozav and
PopPaul2021
as code owners
December 11, 2023 17:12
IuliaCMoldovan
requested changes
Dec 14, 2023
IuliaCMoldovan
requested changes
Jan 8, 2024
AndreiGrozav
requested changes
Feb 12, 2024
Please delete in another commit the ad9083_vna project from this repo, since it was the initial version of the 8ch VNA. |
zahitevrenkaya
force-pushed
the
adi_vna_8ch
branch
from
February 27, 2024 18:37
0521097
to
b99622b
Compare
zahitevrenkaya
requested review from
gastmaier,
StancaPop,
LBFFilho,
podgori,
alin724,
AndrDragomir,
bluncan,
laurent-19,
ladace and
sarpadi
as code owners
March 1, 2024 19:45
zahitevrenkaya
force-pushed
the
adi_vna_8ch
branch
from
March 6, 2024 14:48
10efee3
to
1c7c4a2
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Initial version of 8ch VNA HDL implementation. The design is based on the 4ch HDL design.
One type of CW about ad_3w_spi was coming from a component which is used in the same way it was being used in 4ch design. Therefore, I kept it as it is. HW was functioning as expected.
PR Type
PR Checklist