Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make clean #1252

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Fix make clean #1252

merged 3 commits into from
Jan 23, 2024
+9 −4

Conversation

AndreiGrozav
Copy link
Contributor

PR Description

This PR fixes clean-all target and adds ,lock files to the git ignore list.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@AndreiGrozav
scripts:project_xilinx.mk: Fix make clean-all target
53c5dee 
Signed-off-by: AndreiGrozav <andrei.grozav@analog.com>
@AndreiGrozav
Add library .lock files to git ignore
5bc355f 
Signed-off-by: AndreiGrozav <andrei.grozav@analog.com>
IuliaCMoldovan
IuliaCMoldovan previously approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@IuliaCMoldovan IuliaCMoldovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and it fixes the problems

@gastmaier
scripts:project_intel.mk: Fix make clean-all target
b485b09 
Signed-off-by: Jorge Marques <jorge.marques@analog.com>
gastmaier
gastmaier requested changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing intel update, would prefer if it used the same approach of library/Makefile

PopPaul2021
PopPaul2021 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@PopPaul2021 PopPaul2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a Xilinx and Intel project and it fixes the issues.

@AndreiGrozav AndreiGrozav merged commit 231632e into main Jan 23, 2024
1 of 2 checks passed
@AndreiGrozav AndreiGrozav deleted the fix_make_clean branch January 23, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PopPaul2021 PopPaul2021 PopPaul2021 approved these changes

@IuliaCMoldovan IuliaCMoldovan IuliaCMoldovan approved these changes

@gastmaier gastmaier gastmaier approved these changes

@acostina acostina Awaiting requested review from acostina acostina is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndreiGrozav @gastmaier @IuliaCMoldovan @PopPaul2021