util_axis_fifo: Update #1255
Merged
util_axis_fifo: Update #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added missing signal drivers for tlast and tkeep Signed-off-by: Istvan-Zsolt Szekely <istvan.szekely@analog.com>
IstvanZsSzekely
requested review from
acostina,
AndreiGrozav and
PopPaul2021
as code owners
|
Just regarding the guideline checker action, could you update the copyright year? |
Signed-off-by: Istvan-Zsolt Szekely <istvan.szekely@analog.com>
IstvanZsSzekely
force-pushed
the
util_axis_fifo
branch
from
a23208b to
1e1634c
Compare
acostina
approved these changes
Jan 26, 2024
AndrDragomir
pushed a commit
that referenced
this pull request
Feb 1, 2024
* util_axis_fifo: Update - Added missing signal drivers for tlast and tkeep Signed-off-by: Istvan-Zsolt Szekely <istvan.szekely@analog.com>
bia1708
pushed a commit
to bia1708/hdl
that referenced
this pull request
Apr 5, 2024
* util_axis_fifo: Update - Added missing signal drivers for tlast and tkeep Signed-off-by: Istvan-Zsolt Szekely <istvan.szekely@analog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Added missing signal drivers for tlast and tkeep that would otherwise produce a no driver warning, which can lead to unexpected behavior of the design.
The new warning that now appears is that the respective signals are hard wire to 0 in case of tlast and to 1 in case of tkeep, but this is isn't a problem at all.
PR Type
PR Checklist