Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projects/adrv9026: Add reference design for ADRV9026+ZCU102 #1256

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

AndrDragomir
Copy link
Contributor

PR Description

Initial design for Madura (adrv9026)
Linux and no-OS support tested in hardware

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

Copy link
Contributor

@acostina acostina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the project looks fine. One thing that needs to be tested in hardware is that the DMA on the RX path can handle the maximum rate, as it has as input 128bits@250 MHz and output 128bits@250MHz. You could try to increase PL1 clock to around 300MHz.
Other than that, there are small cleanup comments

projects/adrv9026/Makefile Outdated Show resolved Hide resolved
projects/adrv9026/common/adrv9026_bd.tcl Outdated Show resolved Hide resolved
projects/adrv9026/common/adrv9026_bd.tcl Outdated Show resolved Hide resolved
projects/adrv9026/common/adrv9026_bd.tcl Show resolved Hide resolved
projects/adrv9026/zcu102/Makefile Outdated Show resolved Hide resolved
projects/adrv9026/zcu102/system_project.tcl Outdated Show resolved Hide resolved
projects/adrv9026/zcu102/system_top.v Outdated Show resolved Hide resolved
.tx_sync_0 (tx_sync),
.tx_sysref_0 (sysref));

endmodule
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra new line should be removed

@AndrDragomir AndrDragomir force-pushed the adrv9026_zcu102 branch 2 times, most recently from 5c960f5 to 58a8f11 Compare January 30, 2024 08:42
acostina
acostina previously approved these changes Jan 30, 2024
Copy link
Contributor

@IuliaCMoldovan IuliaCMoldovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all files except for the Makefiles, the copyright range should be 2023 - 2024 (as the Makefile is autogenerated and it will be 2018 - 2024)

projects/adrv9026/zcu102/system_project.tcl Outdated Show resolved Hide resolved
projects/adrv9026/zcu102/system_top.v Outdated Show resolved Hide resolved
Signed-off-by: AndrDragomir <andrei.dragomir@analog.com>
@AndrDragomir
Copy link
Contributor Author

Updated

@AndrDragomir AndrDragomir merged commit 74a190d into main Feb 2, 2024
1 of 2 checks passed
@AndrDragomir AndrDragomir deleted the adrv9026_zcu102 branch February 2, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants