-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
projects/adrv9026: Add reference design for ADRV9026+ZCU102 #1256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the project looks fine. One thing that needs to be tested in hardware is that the DMA on the RX path can handle the maximum rate, as it has as input 128bits@250 MHz and output 128bits@250MHz. You could try to increase PL1 clock to around 300MHz.
Other than that, there are small cleanup comments
.tx_sync_0 (tx_sync), | ||
.tx_sysref_0 (sysref)); | ||
|
||
endmodule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra new line should be removed
5c960f5
to
58a8f11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all files except for the Makefiles, the copyright range should be 2023 - 2024 (as the Makefile is autogenerated and it will be 2018 - 2024)
5099767
to
f893cf2
Compare
Signed-off-by: AndrDragomir <andrei.dragomir@analog.com>
f893cf2
to
88ae5de
Compare
Updated |
PR Description
Initial design for Madura (adrv9026)
Linux and no-OS support tested in hardware
PR Type
PR Checklist