Skip to content

SPI Engine: add offload looping #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

SPI Engine: add offload looping #1292

wants to merge 1 commit into from

Conversation

LBFFilho
Copy link
Contributor

@LBFFilho LBFFilho commented Mar 20, 2024 •
edited
Loading

PR Description

Add two instructions for hardware looping: Loop Start and Loop End. This implementations makes it so both instructions only work on Offload mode, being ignored for direct SPI.

This is one of two similar draft PRs introducing this feature (compare and contrast #1293).

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@LBFFilho
SPI Engine: add offload looping
2eba037 
Add two instructions for hardware looping: Loop Start and Loop End.
This implementations makes it so both instructions only work on
Offload mode, being ignored for direct SPI.

Signed-off-by: Laez Barbosa <laez.barbosa@analog.com>
@LBFFilho LBFFilho marked this pull request as draft March 20, 2024 14:18
@LBFFilho LBFFilho mentioned this pull request Mar 20, 2024
Closed
12 tasks
@LBFFilho
Copy link
Contributor Author

New test used: analogdevicesinc/testbenches#83

@LBFFilho LBFFilho requested a review from sarpadi March 20, 2024 14:28
@LBFFilho LBFFilho closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IuliaCMoldovan IuliaCMoldovan Awaiting requested review from IuliaCMoldovan IuliaCMoldovan is a code owner

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier is a code owner

@StancaPop StancaPop Awaiting requested review from StancaPop StancaPop is a code owner

@acostina acostina Awaiting requested review from acostina

@AndreiGrozav AndreiGrozav Awaiting requested review from AndreiGrozav

@PopPaul2021 PopPaul2021 Awaiting requested review from PopPaul2021

@sarpadi sarpadi Awaiting requested review from sarpadi sarpadi is a code owner

@podgori podgori Awaiting requested review from podgori podgori will be requested when the pull request is marked ready for review podgori is a code owner

@ladace ladace Awaiting requested review from ladace ladace will be requested when the pull request is marked ready for review ladace is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LBFFilho