Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing register selection for any ID in 'library/axi_clock_monitor/axi_clock_monitor.v'. #1295

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

Villyam
Copy link
Contributor

@Villyam Villyam commented Mar 25, 2024

PR Description

  • The IP was building correctly only with the ID set to 0, because the ID section was included in the register selector, but the ID part in the register addresses is 6'b0.
  • For this reason when the ID was other then 0, the relevant part of the IP fell out during synthesis.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@Villyam
Copy link
Contributor Author

Villyam commented Mar 26, 2024

Version 2.

@Villyam
Copy link
Contributor Author

Villyam commented Mar 26, 2024

Version 3.

@Villyam
Copy link
Contributor Author

Villyam commented Mar 26, 2024

Version 4.

Signed-off-by: Villyam <Vilmoscsaba.Jozsa@analog.com>
@Villyam Villyam force-pushed the axi_clock_monitor_fix branch from 0ae22da to 65c0411 Compare March 26, 2024 16:49
@Villyam Villyam requested a review from AndreiGrozav March 26, 2024 16:50
@Villyam Villyam merged commit 5ebd950 into main Mar 28, 2024
1 of 3 checks passed
@Villyam Villyam deleted the axi_clock_monitor_fix branch March 28, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants