Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment fix in reset, in library/axi_pwm_gen/axi_pwm_gen_regmap.sv #1298

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

Villyam
Copy link
Contributor

@Villyam Villyam commented Mar 28, 2024

PR Description

Replaced blocking assignments with non blocking in reset, in the register map write side.
Lattice tools give error for using blocking assignments at one side and non blocking in the other.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

Lattice tools give error for using blocking assignments at one side
and non blocking in the other.

Signed-off-by: Villyam <Vilmoscsaba.Jozsa@analog.com>
@Villyam Villyam merged commit fd81a82 into main Mar 28, 2024
1 of 2 checks passed
@Villyam Villyam deleted the axi_pwm_gen_rst_assign_fix branch March 28, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants