Skip to content

Ad77681evb update #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2024
Merged

Ad77681evb update #1401

merged 2 commits into from
Oct 28, 2024

Conversation

LBFFilho
Copy link
Contributor

@LBFFilho LBFFilho commented Jul 26, 2024 •
edited by PIoandan
Loading

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@sarpadi
Copy link
Contributor

sarpadi commented Aug 1, 2024

Documentation needed

@sarpadi sarpadi force-pushed the ad77681evb_update branch from a949c84 to d612ef1 Compare August 6, 2024 14:05
@sarpadi sarpadi marked this pull request as ready for review October 17, 2024 10:34
StancaPop
StancaPop requested changes Oct 17, 2024
View reviewed changes
IuliaCMoldovan
IuliaCMoldovan requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@IuliaCMoldovan IuliaCMoldovan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last commit should be squashed with 3b4dfc1 .
Commits 1-2 as well should be squashed together (counting from oldest to newest).
Commits 1-2, 4, 5 should have more details, as well as the PR description.

@sarpadi sarpadi force-pushed the ad77681evb_update branch 2 times, most recently from 3de6dae to fdad296 Compare October 17, 2024 11:18
@PIoandan PIoandan force-pushed the ad77681evb_update branch 2 times, most recently from 7377f09 to 8187650 Compare October 17, 2024 13:54
LBFFilho
LBFFilho commented Oct 23, 2024
View reviewed changes
Copy link
Contributor Author

@LBFFilho LBFFilho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just chiming in after the updates everyone has done: everything looks good to me, builds fine.

jonathanns
jonathanns reviewed Oct 24, 2024
View reviewed changes
projects/ad77681evb/zed/system_top.v Outdated
ad7768_sync_in,
ad7768_sync_out,
ad7768_reset}));
.dio_p({ad77681_sync_in,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move ad77681_sync_in GPIO back to number 34 (88 in software) as it was before? this causes a change in software that does not seem necessary, unless there is a reason for that.

StancaPop
StancaPop previously approved these changes Oct 25, 2024
View reviewed changes
@IuliaCMoldovan
Copy link
Contributor

I think the last commit with reverting the GPIO order can be squashed as well

PopPaul2021 and others added 2 commits October 28, 2024 15:21
@PopPaul2021 @PIoandan
ad77681evb: Use spi_engine.tcl script
a7b474a 
Add support for adaq77681, project clean-up

Signed-off-by: sarpadi <sergiu.arpadi@analog.com>
Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com>
@sarpadi @PIoandan
docs/ad77681: Create documentation
7ae7a24 
Signed-off-by: Sergiu Arpadi <sergiu.arpadi@analog.com>
Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com>
@PIoandan
Copy link
Collaborator

I think the last commit with reverting the GPIO order can be squashed as well

Done.

@PIoandan PIoandan merged commit ef0b76b into main Oct 28, 2024
3 of 5 checks passed
@PIoandan PIoandan deleted the ad77681evb_update branch October 28, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanns jonathanns jonathanns left review comments

@IuliaCMoldovan IuliaCMoldovan IuliaCMoldovan approved these changes

@StancaPop StancaPop StancaPop left review comments

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier is a code owner

@PopPaul2021 PopPaul2021 Awaiting requested review from PopPaul2021

@ladace ladace Awaiting requested review from ladace ladace is a code owner

@PIoandan PIoandan Awaiting requested review from PIoandan

Assignees
No one assigned
Labels
doc enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@LBFFilho @sarpadi @IuliaCMoldovan @PIoandan @StancaPop @jonathanns @PopPaul2021