Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library/scripts: Fix FPGA_TECHNOLOGY for VCU118 #1498

Merged
merged 3 commits into from
Nov 11, 2024
Merged

library/scripts: Fix FPGA_TECHNOLOGY for VCU118 #1498

merged 3 commits into from
Nov 11, 2024

Conversation

PopPaul2021
Copy link
Contributor

PR Description

The FPGA_TECHNOLOGY was identified as Ultrascale for VCU118 and it should be Ultrascale+.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@PopPaul2021
library/scripts: Fix FPGA_TECHNOLOGY for VCU118
42419ff 
The FPGA_TECHNOLOGY was identified as Ultrascale for VCU118
and it should be Ultrascale+

Signed-off-by: PopPaul2021 <paul.pop@analog.com>
@bia1708
Copy link
Collaborator

bia1708 commented Oct 28, 2024

RetriggerCI

PopPaul2021 and others added 2 commits November 7, 2024 16:56
@PopPaul2021 @gastmaier
Update library/scripts/adi_xilinx_device_info_enc.tcl after review
e8f7152 
Co-authored-by: Jorge Marques <2892061+gastmaier@users.noreply.github.com>
@PopPaul2021
library/scripts/adi_xilinx_device_info_enc: Indentation fix
412a71a 
Signed-off-by: PopPaul2021 <paul.pop@analog.com>
@PopPaul2021 PopPaul2021 requested a review from gastmaier November 7, 2024 15:01
@PopPaul2021 PopPaul2021 merged commit 36ce2bc into main Nov 11, 2024
3 of 5 checks passed
@PopPaul2021 PopPaul2021 deleted the fix_fpga_type branch November 11, 2024 07:28
IstvanZsSzekely pushed a commit that referenced this pull request Jan 13, 2025
@PopPaul2021 @gastmaier @IstvanZsSzekely
library/scripts: Fix FPGA_TECHNOLOGY for VCU118 (#1498)
9af25f3 
* library/scripts: Fix FPGA_TECHNOLOGY for VCU118

The FPGA_TECHNOLOGY was identified as Ultrascale for VCU118
and it should be Ultrascale+.

Signed-off-by: PopPaul2021 <paul.pop@analog.com>
Co-authored-by: Jorge Marques <2892061+gastmaier@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastmaier gastmaier gastmaier approved these changes

@acostina acostina Awaiting requested review from acostina acostina is a code owner

@AndreiGrozav AndreiGrozav Awaiting requested review from AndreiGrozav AndreiGrozav is a code owner

@sarpadi sarpadi Awaiting requested review from sarpadi sarpadi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PopPaul2021 @bia1708 @gastmaier