Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main]: Fix S10SoC critical warnings #1512

Merged
merged 2 commits into from
Nov 8, 2024
Merged

[main]: Fix S10SoC critical warnings #1512

merged 2 commits into from
Nov 8, 2024

Conversation

bluncan
Copy link
Contributor

@bluncan bluncan commented Nov 8, 2024

PR Description

Fixes some critical warnings that made the Jenkins build fail even though the project compiled successfully.

system_top: Added the missing system_project.tcl parameters.
s10soc_system_assign: Some of the assignments were referencing invalid ports, but the project still compiled fine because Quartus auto-placed those signals.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

Signed-off-by: Bogdan Luncan <bogdan.luncan@analog.com>
LBFFilho
LBFFilho previously approved these changes Nov 8, 2024
@IuliaCMoldovan
Copy link
Contributor

Just to update the year for the Tcl file, and it looks fine to me too

Signed-off-by: Bogdan Luncan <bogdan.luncan@analog.com>
@bluncan
Copy link
Contributor Author

bluncan commented Nov 8, 2024

v2: Updated license header year

@bluncan bluncan requested a review from LBFFilho November 8, 2024 13:38
@bluncan bluncan merged commit db9f01b into main Nov 8, 2024
3 of 5 checks passed
@bluncan bluncan deleted the fix_s10soc_warnings branch November 8, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants