Enhance blocks API #1064
Merged
Enhance blocks API #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that the transfer size requested (in bytes) is not bigger than the size of the block itself. Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Previously, the 'bytes_used' was only used when enqueueing a TX transfer; for RX transfers, the full size of the iio_block was always used. This was arbitrary and confusing. Now, the 'bytes_used' field will be used for RX transfers as well. Signed-off-by: Paul Cercueil <paul@crapouillou.net>
When calling iio_block_enqueue(), if 'bytes_used' is set to zero, then the full block is transferred. Signed-off-by: Paul Cercueil <paul@crapouillou.net>
The bytes_used field can now be set to 0 to default to the block size. Note that for RX transfers, iio_block_enqueue() was already called with bytes_used == 0, which previously meant "transmit 0 bytes and queue for receive". Because the "bytes_used" field is now handled as for RX buffers as well, the behaviour is now "queue for receiving a block size worth of data" which is functionally the same. Signed-off-by: Paul Cercueil <paul@crapouillou.net>
A iio_err() check was performed on the wrong variable. Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Older development versions of Libiio v1.x will try to enqueue blocks of size 0, which is not supported anymore by the current Libiio and IIOD. Signed-off-by: Paul Cercueil <paul@crapouillou.net>
pcercuei
force-pushed
the
pcercuei/better-blocks-api
branch
from
30b1b05
to
5085ee3
Compare
rgetz
approved these changes
Oct 5, 2023
mhennerich
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of #1035, which does not depend on the DMABUF IIO interface being merged into the upstream Linux kernel.
I create a separate PR so that these can be merged sooner.