Fix cyclic mode to IIOD v0.x #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhennerich
approved these changes
Dec 11, 2023
The CLOCK_REALTIME clock may jump in time, which can be a huge problem when computing timeouts. Use the CLOCK_MONOTONIC one instead, which does not have this problem. Signed-off-by: Paul Cercueil <paul@crapouillou.net>
When the buffer creation failed, entry->buf was left to whatever error pointer it had previously, instead of being reset to NULL; cleanup code would subsequently try to destroy the buffer once again with an invalid pointer. Signed-off-by: Paul Cercueil <paul@crapouillou.net>
IIOD v0.x supports enqueueing cyclic blocks, but it needs to know about it when the iio_buffer is opened through the "OPEN" command. As iiod-client calls this command when the buffer is to be enabled, pass an extra "cyclic" parameter to .buffer_enable(), always set to "false" for now. Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Instead of continuously sending the same block again and again, set the "cyclic" parameter of the .enable_buffer() backend callback to the value of the "cyclic" parameter of the last call to iio_buffer_enqueue(). Signed-off-by: Paul Cercueil <paul@crapouillou.net>
pcercuei
force-pushed
the
pcercuei/fix-cyclic
branch
from
970551a
to
b8f3ea0
Compare
tfcollins
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some misc. fixes, alongside a rework of the interface to v0.x IIOD, which did not support cyclic buffers properly.
Fixes #1097.