Better support for enqueue/dequeue errors #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Codacy report looks completely bogus to me, or do I not know C? |
mhennerich
approved these changes
Jan 12, 2024
We need one mask to know whether a block has been enqueued (bit set) or dequeued (bit clear) from the kernel interface, and one flag to know whether the libiio application already tried to enqueue or dequeue the block. Signed-off-by: Paul Cercueil <paul@crapouillou.net>
pcercuei
force-pushed
the
pcercuei/handle-retry-dequeue
branch
2 times, most recently
from
afbf8b1
to
a58629c
Compare
The IIOD_OP_TRANSFER_BLOCK command would atomically enqueue then dequeue the given block. The problem with that, was that on error it was not possible to know which of the two operations was the cause of the error. Change this by encoding the return value in a way that we can deduce which of the two operations failed. Then, if the enqueue failed, the block will be marked as not enqueued, and can be enqueued again. If the dequeue failed, the block is still marked as enqueued, and the next dequeue attempt will see the use of the IIOD_OP_RETRY_DEQUEUE_BLOCK command, which will only dequeue the block. Signed-off-by: Paul Cercueil <paul@crapouillou.net>
When handling the IIOD_OP_TRANSFER_BLOCK, we need a way to tell the client which one of the two operations (enqueue or dequeue) failed. Do that by shifting left the error code by 16 bits if the enqueue failed, and by not shifting the value if the dequeue failed. Signed-off-by: Paul Cercueil <paul@crapouillou.net>
During a previous IIOD_OP_TRANSFER_BLOCK command, if the enqueue succeeded but dequeue failed, the client cannot send the same command again, as it would try to enqueue again. Instead, it will send a IIOD_RETRY_DEQUEUE_BLOCK, which will only attempt to dequeue the block. Signed-off-by: Paul Cercueil <paul@crapouillou.net>
pcercuei
force-pushed
the
pcercuei/handle-retry-dequeue
branch
from
a58629c
to
b6576dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the IIOD protocol has a single command for enqueue + dequeue, in case of an error we need to have a way to know which operation failed, so that the client can retry without having to tear down the whole IIO buffer.
Fixes #1109.