channel: Correct linear x/y/z modifier names #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure where the `*-g` names came from, but the kernel calls them `linear_*`[1]. This fixes an error when using the Bosch BNO055, which is the only user of these modifiers. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/iio/industrialio-core.c?id=83a7eefedc9b56fe7bfeff13b6c7356688ffa670#n147 Signed-off-by: Chris Spencer <spencercw@gmail.com>
spencercw
requested review from
cristina-suteu,
dNechita and
mhennerich
as code owners
|
According to : torvalds/linux@bcc57a4 - things have been broken for a couple years... Likely a missing part in https://github.com/analogdevicesinc/libiio/blob/main/CI/azure/check_kernel.sh which should be checking drivers/iio/industrialio-core.c as well... Then you would keep up to date... |
rgetz
approved these changes
Jun 11, 2024
mhennerich
approved these changes
Jun 12, 2024
|
LGTM |
rgetz
added a commit
to rgetz/libiio
that referenced
this pull request
Jul 21, 2024
This would have found and avoided analogdevicesinc#1176 Signed-off-by: Robin Getz <rgetz@mathworks.com>
rgetz
added a commit
to rgetz/libiio
that referenced
this pull request
Jul 22, 2024
This would have found and avoided analogdevicesinc#1176 Signed-off-by: Robin Getz <rgetz@mathworks.com>
rgetz
added a commit
to rgetz/libiio
that referenced
this pull request
Aug 4, 2024
This would have found and avoided analogdevicesinc#1176 Signed-off-by: Robin Getz <rgetz@mathworks.com>
rgetz
added a commit
to rgetz/libiio
that referenced
this pull request
Aug 4, 2024
This would have found and avoided analogdevicesinc#1176 Signed-off-by: Robin Getz <rgetz@mathworks.com>
mhennerich
pushed a commit
that referenced
this pull request
Aug 30, 2024
This would have found and avoided #1176 Signed-off-by: Robin Getz <rgetz@mathworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
I'm not sure where the
*-gnames came from, but the kernel calls themlinear_*[1]. This fixes an error when using the Bosch BNO055, which is the only user of these modifiers.[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/iio/industrialio-core.c?id=83a7eefedc9b56fe7bfeff13b6c7356688ffa670#n147
PR Type
PR Checklist