IIOD: Better handle errors of iio_buffer_{refill,push} #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcercuei
force-pushed
the
pcercuei/iiod-handle-kernel-timeout
branch
from
1323fe5
to
e1da15b
Compare
rgetz
reviewed
Jun 23, 2023
Pass the error code to the connected clients, instead of disconnecting them. This means that for a very slow device, a connected client will simply get a -ETIMEDOUT error when a configured timeout expires, and will still be able to communicate with the server. Fixes: #981. Signed-off-by: Paul Cercueil <paul@crapouillou.net>
pcercuei
force-pushed
the
pcercuei/iiod-handle-kernel-timeout
branch
from
e1da15b
to
9209fe0
Compare
|
Updated. |
|
Is the removal of all the IIO_ERROR() on purpose? We no longer print anything out when we use to.... if so - looks good to me - thanks |
Yes. Before, we considered that if Now, we consider that these errors might happen, but they are not errors of IIOD itself. The error codes are therefore sent back to the connected client(s). |
nunojsa
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the error code to the connected clients, instead of disconnecting them.
This means that for a very slow device, a connected client will simply get a -ETIMEDOUT error when a configured timeout expires, and will still be able to communicate with the server.
Fixes: #981.