ADSP-SC598 upstream driver changes v2 #2908

artursartamonovsadi · 2025-08-25T15:34:44Z

Minimal patch set to boot into ADSP-SC598-SOM with initramfs to UART Linux shell.
Based on v1 sent to kernel mailinglist. Tested with ADSP-SC598-SOM RevC

PR Type

Bug fix (a change that fixes an issue)
[x ] New feature (a change that adds new functionality)
Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

[x ] I have conducted a self-review of my own code changes
[x ] I have tested the changes on the relevant hardware
[x ] I have updated the documentation outside this repo accordingly (if there is the case)

pamolloy · 2025-08-26T06:02:54Z

Thanks so much for posting this! @UtsavAgarwalADI and I were chatting about the sign off section for an earlier set of patches. It is probably easier to just discuss it in person, but also take a look at https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by. The two examples at the end of the section are especially helpful.

pamolloy · 2025-08-26T06:08:23Z

It would be good to link to the original mailing list review in the description:

https://lore.kernel.org/lkml/20240912-test-v1-0-458fa57c8ccf@analog.com/

arch/arm64/Kconfig.platforms

drivers/clk/adi/clk-adi-pll.c

drivers/clk/adi/clk.h

pamolloy · 2025-09-24T10:47:06Z

Add SC5xx to the mainline arch/arm64/configs/defconfig using menuconfig

pamolloy · 2025-09-25T10:47:37Z

Before I squash the above fixup commits I have pushed a branch with all the fixups to https://github.com/pamolloy/linux/commits/lkml/20240912-test-v1-0-458fa57c8ccf%40analog.com/cicd-clean-up/ so it is easier to see what changed. Then I'll clean-up the commit messages, which requires rebasing

Add headers for GPIO port management, RCU and general system configuration Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Co-developed-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Greg Malysa <malysagreg@gmail.com> Co-developed-by: Utsav Agarwal <Utsav.Agarwal@analog.com> Signed-off-by: Utsav Agarwal <Utsav.Agarwal@analog.com> Co-developed-by: Arturs Artamonovs <arturs.artamonovs@analog.com> Signed-off-by: Arturs Artamonovs <arturs.artamonovs@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

pamolloy · 2025-09-25T13:58:06Z

@artursartamonovsadi tested it and it was able to boot. We may need to revert the I2C driver, but I'll figure that out as I rebase adsp-main-6.12 onto these patches. This is just the first round of clean-up so it doesn't need to be perfect.

artursartamonovsadi

Went trough mailinglist comments and added if those wheren't addressed, so possible to track those here.

artursartamonovsadi · 2025-09-25T14:38:10Z

drivers/i2c/busses/i2c-adi-sc5xx.c

+	struct clk *sclk;
+};
+
+static void adi_twi_handle_interrupt(struct adi_twi_iface *i2c,


change name from adi_twi to match driver to adi_i2c

artursartamonovsadi · 2025-09-25T14:49:14Z

arch/arm64/boot/dts/adi/sc598-som.dtsi

+/ {
+	chosen {
+		stdout-path = &uart1;
+		bootargs = "earlycon=adi_uart,0x31003000 console=ttySC0,115200 mem=224M";


Comment from the mailinglist:

You should not need the mem= and earlycon= arguments, as that data is already part of the stdout-path property and the memory node.

Second comment:
Drop entire bootargs. Look how other SoCs do it, if you need port speed.

artursartamonovsadi · 2025-09-25T14:50:13Z

arch/arm64/boot/dts/adi/sc59x-64.dtsi

+		serial0 = &uart0;
+		serial2 = &uart2;
+		serial3 = &uart3;
+	};


Comments from mailinglist:

The aliases are board specific, please only list the ones that are actually enabled and wired on on a particular board, and make the aliases match the labels on the board rather than the internal components of hte chip.

move to board DTS

artursartamonovsadi · 2025-09-25T14:51:57Z

arch/arm64/boot/dts/adi/sc59x-64.dtsi

+			reg = <0x0 0x0>;
+			enable-method = "spin-table";
+			cpu-release-addr = <0x0 0xdeadbeef>;
+			clocks = <&clk_cgu0 ADSP_CLK_ARM>, <&clk_cgu0 ADSP_CLK_DDR>;


Comments from mailinglist:

Is that the actual address? It looks like some placeholder that should not have been here.

artursartamonovsadi · 2025-09-25T15:04:58Z

Documentation/devicetree/bindings/clock/adi,sc5xx-clocks.yaml

+      #clock-cells = <1>;
+      clocks = <&sys_clkin0>, <&sys_clkin1>;
+      clock-names = "sys_clkin0", "sys_clkin1";
+      status = "okay";


remove status

artursartamonovsadi · 2025-09-26T10:19:09Z

arch/arm64/boot/dts/adi/sc59x-64.dtsi

+			clock-output-names = "sys_clkin0";
+		};
+
+		sys_clkin1: oscillator@2 {


Comment from mailinglist:

How are these properties of the SoC? Where are they located physically? See DTS coding style.

artursartamonovsadi · 2025-09-26T10:20:23Z

arch/arm64/boot/dts/adi/sc59x-64.dtsi

+		status = "okay";
+	};
+
+	scb: scb-bus {


Comment from mailinglist:

What is scb-bus? See DTS coding style or any other SoC. This is supposed to be just sco@ with proper unit address.

artursartamonovsadi · 2025-09-26T10:21:19Z

arch/arm64/boot/dts/adi/sc59x-64.dtsi

+			status = "disabled";
+		};
+
+		i2c0: twi@31001400 {


Comment from mailinglist:

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Completely wrong order of properties. Please follow DTS coding style.

artursartamonovsadi · 2025-09-26T10:21:42Z

arch/arm64/boot/dts/adi/sc59x-64.dtsi

+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "adi,sc5xx-i2c";
+			reg = <0x31001400 0xFF>;


Lowe case hex?

artursartamonovsadi · 2025-09-26T10:22:38Z

arch/arm64/boot/dts/adi/sc59x-64.dtsi

+			gpio-ranges = <&pinctrl0 0 96 16>;
+		};
+
+		gph: gport@31004380 {


Comment:
Node names should be generic

Support custom GPIO pin configuration for non-GPIO functions Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Co-developed-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Greg Malysa <malysagreg@gmail.com> Co-developed-by: Utsav Agarwal <Utsav.Agarwal@analog.com> Signed-off-by: Utsav Agarwal <Utsav.Agarwal@analog.com> Co-developed-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Support triggering a software reset Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Co-developed-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Greg Malysa <malysagreg@gmail.com> Co-developed-by: Utsav Agarwal <Utsav.Agarwal@analog.com> Signed-off-by: Utsav Agarwal <Utsav.Agarwal@analog.com> Co-developed-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Add bindings for the reset controller in ADI ADSP-SC5xx SoCs Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Co-developed-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Greg Malysa <malysagreg@gmail.com> Co-developed-by: Utsav Agarwal <Utsav.Agarwal@analog.com> Signed-off-by: Utsav Agarwal <Utsav.Agarwal@analog.com> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Add bindings for ADI evaluation boards using ADSP-SC59x SoCs Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Co-developed-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Greg Malysa <malysagreg@gmail.com> Co-developed-by: Utsav Agarwal <Utsav.Agarwal@analog.com> Signed-off-by: Utsav Agarwal <Utsav.Agarwal@analog.com> Co-developed-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Implement the clock tree without dynamic PLL rate change Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Co-developed-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Add ADSP-SC5xx clock driver Co-developed-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Co-developed-by: Utsav Agarwal <Utsav.Agarwal@analog.com> Signed-off-by: Utsav Agarwal <Utsav.Agarwal@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Add device tree bindings for the ADSP-SC5xx clock distribution unit (CDU) and clock generation unit (CGU) Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Co-developed-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

- Support all GPIO ports - Each gpio support seperate PINT interrupt controller Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Co-developed-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Add bindings for ADSP-SC5xx general-purpose ports, pin multiplexing, general-purpose input/output (GPIO) functionality, and pin interrupts. Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Co-developed-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Support switching GPIO pin functions Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Co-developed-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Add bindings for the ADSP-SC5xx pinmux control Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Co-developed-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Add I2C support on ADSP-SC5xx SoCs Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Co-developed-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Add bindings for ADSP-SC5xx I2C/TWI Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Co-developed-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

- Support FIFO mode - Support earlyprintk - Support Enable Divide By One support, for higher clock resolutions. Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Co-developed-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Add bindings for the ADSP-SC5xx UART Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Co-developed-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Add support for the ADSP-SC59x SoC, EV-SC598-SOM and EV-SOMCRR-EZKIT Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Co-developed-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Greg Malysa <malysagreg@gmail.com> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Add Arturs Artamonov as the maintainer of ADSP-SC5xx SoCs Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Add initial support for the ADSP-SC598 Signed-off-by: Philip Molloy <philip@philipmolloy.com>

artursartamonovsadi requested review from pamolloy, vasbimpikasadi, UtsavAgarwalADI and CalebEthridgeADI August 25, 2025 15:34

artursartamonovsadi requested review from nunojsa, mhennerich, dbogdan, btogorean, chegbeli, buha, amiclaus, rbolboac, danmois, CiprianRegus and machschmitt as code owners August 25, 2025 15:34

pamolloy requested a review from gastmaier August 26, 2025 05:59

pamolloy added this to ADSP Aug 26, 2025

pamolloy moved this to In Development in ADSP Aug 26, 2025

pamolloy assigned artursartamonovsadi Aug 26, 2025

pamolloy reviewed Aug 26, 2025

View reviewed changes

arch/arm64/Kconfig.platforms Show resolved Hide resolved

pamolloy reviewed Aug 26, 2025

View reviewed changes

arch/arm64/Kconfig.platforms Outdated Show resolved Hide resolved

pamolloy reviewed Aug 26, 2025

View reviewed changes

drivers/clk/adi/clk-adi-pll.c Outdated Show resolved Hide resolved

pamolloy reviewed Aug 26, 2025

View reviewed changes

drivers/clk/adi/clk.h Outdated Show resolved Hide resolved

pamolloy reviewed Aug 26, 2025

View reviewed changes

drivers/clk/adi/clk.h Outdated Show resolved Hide resolved

artursartamonovsadi removed request for gastmaier, buha, CiprianRegus and amiclaus August 26, 2025 08:56

pamolloy force-pushed the adsp-6.12.38-y-patchset branch from 9fe49f3 to 1231b43 Compare September 24, 2025 10:04

pamolloy force-pushed the adsp-6.12.38-y-patchset branch from b079d72 to c82036f Compare September 25, 2025 09:00

pamolloy force-pushed the adsp-6.12.38-y-patchset branch from cf02f09 to 01bf2bc Compare September 25, 2025 11:17

pamolloy force-pushed the adsp-6.12.38-y-patchset branch 2 times, most recently from 79aa263 to b825d4e Compare September 25, 2025 13:42

pamolloy requested a review from gastmaier September 25, 2025 13:45

artursartamonovsadi commented Sep 26, 2025

View reviewed changes

artursartamonovsadi and others added 18 commits September 29, 2025 16:57

MAINTAINERS: Add maintainer for ADSP-SC5xx SoCs

37c8915

Add Arturs Artamonov as the maintainer of ADSP-SC5xx SoCs Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Philip Molloy <philip.molloy@analog.com>

arm64: defconfig: Add initial support for the ADSP-SC598

940d44c

Add initial support for the ADSP-SC598 Signed-off-by: Philip Molloy <philip@philipmolloy.com>

artursartamonovsadi force-pushed the adsp-6.12.38-y-patchset branch from d4bcd8a to 940d44c Compare September 29, 2025 15:58

ADSP-SC598 upstream driver changes v2 #2908

Are you sure you want to change the base?

ADSP-SC598 upstream driver changes v2 #2908

Uh oh!

Conversation

artursartamonovsadi commented Aug 25, 2025

PR Type

PR Checklist

Uh oh!

pamolloy commented Aug 26, 2025

Uh oh!

pamolloy commented Aug 26, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pamolloy commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pamolloy commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pamolloy commented Sep 25, 2025

Uh oh!

artursartamonovsadi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pamolloy commented Sep 24, 2025 •

edited

Loading

pamolloy commented Sep 25, 2025 •

edited

Loading