Update ad9208.c #2940
Open
Update ad9208.c #2940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating Min values in response to issue analogdevicesinc#2811
union-galactic
requested review from
nunojsa,
mhennerich,
dbogdan,
btogorean,
chegbeli,
buha,
amiclaus,
rbolboac,
danmois,
CiprianRegus and
machschmitt
as code owners
nunojsa
reviewed
Sep 16, 2025
There was a problem hiding this comment.
Thanks for the path. In addition to my code comment, some things to improve:
- The commit needs a Signed-of-by tag. Run
git commit -swhen committing your changes; - Please run
git log --oneline drivers/iio/adcand see the style for the commit subject; - Related with 2, add a better commit description. Maybe use some of the description of the issue.
| phy->ad9208.input_clk_min_hz = 24000000ULL; | ||
| phy->ad9208.input_clk_max_hz = 1300000000ULL; | ||
| phy->ad9208.adc_clk_min_hz = 625000000ULL; | ||
| phy->ad9208.adc_clk_min_hz = 24000000ULL; |
There was a problem hiding this comment.
But now you broke systems running AD9208-1300 right? So you need to define a new compatible and to be consistent do it as for the ID_DUAL case so you can differentiate between variants and set the proper value. This would be straight forward way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Min values in response to issue #2811
PR Checklist