-
Notifications
You must be signed in to change notification settings - Fork 1.8k
drivers:adc:ltc2378: Add support for LTC2378-20 #2794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add initial header and source files for LTC2378 driver. Signed-off-by: Cherrence Sarip <cherrence.sarip@analog.com>
Add initial header and source file for LTC2378 IIO driver. Signed-off-by: Cherrence Sarip <cherrence.sarip@analog.com>
Add README.rst documentation file for LTC2378 alongside other documentation related files. Signed-off-by: Cherrence Sarip <cherrence.sarip@analog.com>
fb21a03 to
055ec97
Compare
Add initial project files for both basic and IIO examples for LTC2378. Signed-off-by: Cherrence Sarip <cherrence.sarip@analog.com>
055ec97 to
8e480e9
Compare
Add README.rst documentation file for project alongside other documentation related files. Signed-off-by: Cherrence Sarip <cherrence.sarip@analog.com>
8e480e9 to
e1c00ca
Compare
|
It appears to have the same failed checks as PR #2783. Unless all checks are required to pass, this PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall, but the documentation issues ar valid. check for the warnings in the log file, those are treated as errors too.
| no_os_udelay(1); | ||
| } | ||
|
|
||
| uint8_t buf[3] = {0}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
declarations at start of the function.
|
|
||
| case LTC2378_IIO_SCALE: | ||
| vals[0] = ltc2378->vref_uv; | ||
| if (ltc2378->input_mode == LTC2378_UNIPOLAR) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no brackets if only one expression guarded.
| return iio_format_value(buf, len, IIO_VAL_INT, 1, vals); | ||
| } | ||
|
|
||
| int32_t voltage_uv; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variable declaration at start of function.
Pull Request Description
This PR adds initial driver support for the LTC2378-20 20-bit SAR ADC with project examples.
Driver Features Implemented:
Project Examples Added:
PR Type
PR Checklist