ad514x ops update #2796
Open
ad514x ops update #2796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exit on ad5141, ad5142 and ad5143 Signed-off-by: Anush Shetty <anush.shetty@analog.com>
…ale command usage Signed-off-by: Anush Shetty <anush.shetty@analog.com>
…5142, and AD5144 Signed-off-by: Anush Shetty <anush.shetty@analog.com>
Shetty-Anush
requested review from
CiprianRegus,
amiclaus,
buha,
danmois,
dbogdan and
rbolboac
as code owners
amiclaus
reviewed
Oct 24, 2025
There was a problem hiding this comment.
please add a body to your commits. also have a look at https://analogdevicesinc.github.io/no-OS/contributing.html and follow the 50/72 rule.
|
|
||
| cmd.is_readback = false; | ||
|
|
||
| ret = ad5141_dpot_send_cmd(desc, &cmd); |
| cmd.control = 0x9; | ||
| cmd.address = ad5141_dpot_cmd_addr[chn]; | ||
| cmd.data = nEnable; | ||
| if (IsTopScale == true) { |
There was a problem hiding this comment.
no brackets if guarding only one expression.
| */ | ||
| int ad5141_dpot_top_bottom_scale_enable(struct dpot_dev *desc, | ||
| enum dpot_chn_type chn, | ||
| bool IsTopScale, |
There was a problem hiding this comment.
no camel case, only snake case please. check the entire code for these occurences.
| return ret; | ||
|
|
||
| /* Enter/Exit the top scale or bottom scale (command #12 or command #13) */ | ||
| cmd.control = 0x9; |
There was a problem hiding this comment.
what is 0x9?. deserves a macro.
| cmd.control = 0x9; | ||
| cmd.address = ad5142_dpot_cmd_addr[chn]; | ||
| cmd.data = nEnable; | ||
| if (IsTopScale == true) { |
| cmd.address = ad5142_dpot_cmd_addr[chn]; | ||
| cmd.data = nEnable; | ||
| if (IsTopScale == true) { | ||
| cmd.data |= 0x80; |
There was a problem hiding this comment.
magic number. please add suggestive macro.
| cmd.control = 0x9; | ||
| cmd.address = ad5143_dpot_cmd_addr[chn]; | ||
| cmd.data = nEnable; | ||
| if (IsTopScale == true) { |
|
|
||
| cmd.is_readback = false; | ||
|
|
||
| ret = ad5143_dpot_send_cmd(desc, &cmd); |
| * @param desc - digipot descriptor. | ||
| * @param chn - digipot channel. | ||
| * @param IsTopScale - boolean flag to indicat top scale or bottom scale. | ||
| * @param IsTopScale - boolean flag to indicate top scale or bottom scale. |
There was a problem hiding this comment.
this commit should be squashed into the one that is adding the functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist