Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Generic TDD Engine (TDDN) #527

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Add support for Generic TDD Engine (TDDN) #527

merged 3 commits into from
Mar 11, 2024

Conversation

podgori
Copy link
Contributor

@podgori podgori commented Feb 7, 2024

Description

Adding support for TDDN:

  • Added tddn.py in library
  • Added pluto_tddn.py example script
  • Updated the documentation to include the TDDN

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this been tested?

The example script was tested on Pluto in Phaser mode. The TDD configuration and functionality from pluto_tddn.py example was validated and tested with an oscilloscope.

Documentation

TDDN wiki page: https://wiki.analog.com/resources/fpga/docs/axi_tdd

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: Ionut Podgoreanu <ionut.podgoreanu@analog.com>
Add test example for the Generic TDD Engine using Pluto.
Works with Pluto in Phaser mode.

Signed-off-by: Ionut Podgoreanu <ionut.podgoreanu@analog.com>
Copy link

github-actions bot commented Feb 7, 2024

Generated documentation for this PR is available at Link

This comment has been minimized.

Copy link

github-actions bot commented Feb 7, 2024

Unit Test Results

1 436 tests  +12      255 ✔️ ±  0   9m 14s ⏱️ -1s
       1 suites ±  0   1 181 💤 +12 
       1 files   ±  0          0 ±  0 

Results for commit 46b5450. ± Comparison against base commit 89d94fd.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@thorenscientific thorenscientific left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pro-forma after discussion with Jon

@tfcollins
Copy link
Collaborator

@podgori how is this different than the existing TDD class?

@podgori
Copy link
Contributor Author

podgori commented Feb 9, 2024

This class is specific to the Generic TDD engine, the new scalable and standalone TDD IP, which aims to reduce the naming confusion around the existing TDD core built for AD9361, as well as expanding its number of output channels for systems which require more than six controlling signals (up to 32 channels). As such:

  • its properties match the new TDD driver attributes
  • uses a channel class with common properties per channel
  • uses indexed channels

@tfcollins
Copy link
Collaborator

Can we replace the existing design (adi.tdd) with this one?

These attributes are inherited from the ADF4159 and implemented
through debug attributes.

Signed-off-by: Ionut Podgoreanu <ionut.podgoreanu@analog.com>
@podgori
Copy link
Contributor Author

podgori commented Feb 14, 2024

Can we replace the existing design (adi.tdd) with this one?

As discussed, we can leave these 2 classes separate for now.

@tfcollins tfcollins merged commit 2061827 into main Mar 11, 2024
53 of 54 checks passed
@tfcollins tfcollins deleted the dev_tddn branch March 11, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants