Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ad7746 and adxrs290 tests #531

Merged
merged 3 commits into from
May 30, 2024

Conversation

trishaange01
Copy link
Contributor

@trishaange01 trishaange01 commented Feb 12, 2024

Description

The pull request adds test modules for ad7746 and adxrs290 and added attribute tests.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Hardware: ad7746 and adxrs290
  • OS: Windows

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@trishaange01
Copy link
Contributor Author

trishaange01 commented Feb 12, 2024

Hi @tfcollins! I created a new PR for ad7746 and adxrs290 to get the changes from the devices in a single branch. This PR is ready for review. Thanks! :)

@tfcollins tfcollins self-requested a review February 14, 2024 01:30
@tfcollins tfcollins marked this pull request as draft February 14, 2024 01:30
@trishaange01 trishaange01 marked this pull request as ready for review February 14, 2024 02:39
@trishaange01
Copy link
Contributor Author

Hi @tfcollins. This PR is ready for review. Thanks :)

@trishaange01 trishaange01 force-pushed the ad7746_adxrs290_support branch 3 times, most recently from 66b4927 to 65a19e4 Compare April 23, 2024 00:48
@trishaange01
Copy link
Contributor Author

Hi @tfcollins. This PR is ready for review. Thanks! 😊

@trishaange01
Copy link
Contributor Author

Hi @tfcollins. This PR is ready for review. Thanks! :)

@tfcollins tfcollins merged commit 6ca6507 into analogdevicesinc:main May 30, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants