Add support for LTC2672 #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaikiranGudla
force-pushed
the
ltc2672_support
branch
3 times, most recently
from
145697c
to
41535d4
Compare
|
Hi @tfcollins , |
tfcollins
reviewed
Apr 17, 2024
adi/ltc2672.py
Outdated
| """LTC2672 DAC""" | ||
|
|
||
| _complex_data = False | ||
| channel = [] |
There was a problem hiding this comment.
channel should not be a class property or it needs to be reset within the constructor. This creates an issue when you have multiple instances of the class. channel will keep growing
tfcollins
reviewed
Apr 17, 2024
examples/ltc2672_example.py
Outdated
| # STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF | ||
| # THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
|
||
| from adi.ltc2672 import * |
There was a problem hiding this comment.
Please do not use * imports. Just import what you need
tfcollins
requested changes
Apr 17, 2024
Add ltc2672.py driver Add test script, example code Update index.rst, init.py, supported_parts.md files Add ltc2672 rst file Add iio-emu xml file for ltc2672 Update hardware_map.yml emulation context map Signed-off-by: SGudla <Saikiran.Gudla@analog.com>
SaikiranGudla
force-pushed
the
ltc2672_support
branch
from
41535d4
to
3695b49
Compare
|
Change log: Addressed review comments Import ltc2672 class in example file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ltc2672.py driver
Add test script, example code
Update index.rst, init.py, supported_parts.md files Add ltc2672 rst file
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: