adi:ad7134: Add support for ad7134 #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansunil
force-pushed
the
add-support-to-ad7134
branch
6 times, most recently
from
e6fc483
to
48c389f
Compare
|
Changelog: Fixed pylint and build errors |
|
@tfcollins - Could you please review these changes when you get a chance? |
tfcollins
reviewed
Jun 20, 2024
supported_parts.md
Outdated
| @@ -70,6 +70,8 @@ | |||
| - AD5940 | |||
| - AD6676 | |||
| - AD7124 | |||
| - AD7134 | |||
| - AD4134 | |||
There was a problem hiding this comment.
Please put these in numeric order
tfcollins
reviewed
Jun 20, 2024
adi/ad7134.py
Outdated
| # Copyright (C) 2024 Analog Devices, Inc. | ||
| # | ||
| # SPDX short identifier: ADIBSD | ||
| # Copyright (C) 2024 Analog Devices, Inc. |
There was a problem hiding this comment.
Full license not needed. Just the SPDX
tfcollins
reviewed
Jun 20, 2024
adi/ad7134.py
Outdated
| """ AD7134 ADC """ | ||
|
|
||
| _complex_data = False | ||
| channel = [] # type: ignore |
There was a problem hiding this comment.
Should be called "channels". Needs to be reset/initialized in the constructor similar to the issue in the related PR
tfcollins
requested changes
Jun 20, 2024
1. Add pyadi driver for ad7134 family 2. Add example script for data capture with AD7134 3. Add documentation changes
jansunil
force-pushed
the
add-support-to-ad7134
branch
from
48c389f
to
4352b32
Compare
|
Changelog: Addressed review comments
|
|
@tfcollins - Do these changes look good now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: