transactions #2
Merged
transactions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement Wallet and Transaction models with appropriate relationships to the User model. Add corresponding migration files to create wallets and transactions tables with necessary foreign key constraints. This lays the foundation for handling user transactions and wallet balances in the database.
Created an `init.sql` file to initialize `payment` and `payment-testing` databases if they do not exist. Updated `docker-compose.dev.yml` to mount the init script, ensuring the databases are set up during the container initialization.
Restructure token handling by extracting token data logic and load wallet relationships. Introduce TokenBuilder for better test token creation and HttpTestCase improvements for easier authentication setup. Added ShowUserTest to verify user details and adjusted test cases accordingly.
Introduce TransactionController for handling transfers, including validation and exception handling. Enhance User model to create wallet on user creation. Update routes and add repositories for listing users and shopkeepers.
Introduced TransactionFactory and WalletFactory for easier creation of relevant models in tests. Added ListUsersTest and ListShopkeepersTest for listing user types and TransferTest for validating transfer functionality. These enhancements improve test coverage and development efficiency.
Refactored `TransactionService` to use parallel execution for authorizations and notifications, including retry mechanisms. Introduced new service requests, dependencies, and configuration for external APIs, and enhanced validation to prevent shopkeepers from initiating payments.
…onService Removed TransferTest and replaced it with an API version located under the Api namespace for consistency. Reorganized other tests into the correct directory structure, and added a new TransactionServiceTest to cover transaction-related test cases.
Moved transfer validation logic from TransferRequest to TransactionService. Introduced `ShopkeeperCannotTransferException` to handle shopkeeper-specific validation. Added a new test to verify shopkeeper transfer restriction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.