🐛 Bug fix: logout not always working

Fixed a bug where logout wasn`t working in all browsers
anditv21 · Oct 10, 2024 · 59c9d80 · 59c9d80
1 parent d5f6b42
commit 59c9d80
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 12 deletions.
diff --git a/src/app/controllers/UserController.php b/src/app/controllers/UserController.php
@@ -36,15 +36,12 @@ public function logoutUser($log = true)
         if ($log) {
             $this->log($username, "Logged out", auth_logs);
         }
-
-        setcookie("login_cookie", "", time() - 3600, '/');
-        session_unset();
-        $_SESSION = [];
-        $_SESSION = array();
-        session_destroy();
-        Util::redirect("/auth/login.php");
+        Util::redirect("/auth/login.php?action=logout");
     }
 
+
+
+
     public function getUserArray()
     {
         return $this->UserArray();

diff --git a/src/auth/login.php b/src/auth/login.php
@@ -7,9 +7,23 @@
 
 Session::init();
 
-if (Session::isLogged()) {
-    Util::redirect('/');
+
+if (Util::securevar($_SERVER['REQUEST_METHOD']) === 'GET') {
+    if (isset($_GET['action'])) {
+        $data = Util::securevar($_GET['action']);
+
+        if ($data === 'logout') {
+            setcookie("login_cookie", "", time() - 3600, '/');
+            session_unset();
+            $_SESSION = [];
+            session_destroy();
+            Util::redirect('/auth/login.php');
+        }
+    }
 }
+
+
+
 if (Util::securevar($_SERVER['REQUEST_METHOD']) === 'POST') {
     if (isset($_POST)) {
         $data = Util::securevar($_POST);

diff --git a/src/auth/logout.php b/src/auth/logout.php
@@ -10,5 +10,3 @@
 
 $user = new UserController();
 $user->logoutUser();
-
-Util::redirect('/auth/login.php');
diff --git a/src/index.php b/src/index.php
@@ -204,7 +204,7 @@
             $loginfails = Session::get("loginfails");
 if ($loginfails > 0) : ?>
             <br>
-            <em style="color: red"; >Security Warning: <?php Util::display(Util::securevar($loginfails)); ?> failed login attempts <img title="" data-toggle="tooltip" data-placement="top" src="assets/images/warning.png" width="15" height="15" data-original-title="Resets after every successful login."></em>
+            <em style="color: red"; >Security Warning: <?php Util::display(Util::securevar($loginfails)); ?> failed login attempts <img title="" data-toggle="tooltip" data-placement="top" src="assets/img/warning.png" width="15" height="15" data-original-title="Resets after every successful login."></em>
 
             <?php endif; ?>
 </body>