Added new option (minHeight) to have a different height to width#9
Open
wayferer wants to merge 2 commits intoandreas-pihlstrom:masterfrom
Open
Added new option (minHeight) to have a different height to width#9wayferer wants to merge 2 commits intoandreas-pihlstrom:masterfrom
wayferer wants to merge 2 commits intoandreas-pihlstrom:masterfrom
Conversation
|
Hi There! I used your branch, because i really needed to have a min height property. It trew an error on resizing. Since i wrote a custom responsive behavior for my project, it was not an issue commenting this one out. Regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
We had a requirement for the box height to be different to the box width so I have made some changes (new option of 'minHeight') and while it seems to be working (IE8+, Chrome, Firefox) with 'resizeToFit: false' I would love some feedback and help to get it working with 'resizeToFit: true' if possible (or maybe this defeats the purpose?).
Thanks!