grammatical/typo errors fixed #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veilm
reviewed
Jun 24, 2021
| name: "Programming Paradigms", | ||
| description: { | ||
| text: "Learn how programming languages can be categoried into different paraigmes based on their features.", | ||
| text: "Learn how programming languages can be categoried into different paradigmes based on their features.", |
There was a problem hiding this comment.
Don't forget to remove the "e" in "paradigmes"
There was a problem hiding this comment.
I've made the changes. Please check
There was a problem hiding this comment.
That looks good, although I think you forgot:
Progressive Webapps > Security > Clickjacking
Change "these kind of" to "these kinds of".
Also, README.md has these same errors, so I guess the changes should be copied over to there as well. It doesn't necessarily have to be part of the same PR, though.
There was a problem hiding this comment.
I have done the change, and as for the README.md I'll create another issue which can be done with a new PR.
veilm
approved these changes
Jun 25, 2021
|
@michaelskyba could you merge it to master please? |
|
I don't have write access to this repo; my only significance is that I own the original issue. |
inthedownpour
added a commit
to inthedownpour/web-skills
that referenced
this pull request
Sep 6, 2021
Junior를 Develop에 merge(andreasbm#53)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues:
Fixes #52 TYPOS
Changes:
I have fixed all the typos and grammatical errors which were visible and enhanced your code a little bit.
I have also solved/ corrected all the given changes in the ISSUE NO. #52
Thanks for making Web Skills, it has been a great resource and really helpful! I was looking for ways to contribute to this wonderfull project by doing something at least.
This PR has been raised under LGMSOC21
Thankyou.