[TASK] Downgrade to PHP 7.4

packages/extension-installer/src/PackagesFileGenerator.php

@@ -21,11 +21,26 @@ private function __construct() {}
 }
 PHP;
 
-    public function __construct(
-        private readonly InstalledRepositoryInterface $repository,
-        private readonly InstallationManager $installationManager,
-        private readonly string $fileToGenerate
-    ) {
+    /**
+     * @readonly
+     */
+    private InstalledRepositoryInterface $repository;
+
+    /**
+     * @readonly
+     */
+    private InstallationManager $installationManager;
+
+    /**
+     * @readonly
+     */
+    private string $fileToGenerate;
+
+    public function __construct(InstalledRepositoryInterface $repository, InstallationManager $installationManager, string $fileToGenerate)
+    {
+        $this->repository = $repository;
+        $this->installationManager = $installationManager;
+        $this->fileToGenerate = $fileToGenerate;
     }
 
     public function generate(): void

packages/fractor-composer-json/src/ComposerJsonFileProcessor.php

@@ -14,16 +14,32 @@
 /**
  * @implements FileProcessor<ComposerJsonFractorRule>
  */
-final readonly class ComposerJsonFileProcessor implements FileProcessor
+final class ComposerJsonFileProcessor implements FileProcessor
 {
+    /**
+     * @var iterable<ComposerJsonFractorRule>
+     * @readonly
+     */
+    private iterable $rules;
+
+    /**
+     * @readonly
+     */
+    private ComposerJsonPrinter $composerJsonPrinter;
+
+    /**
+     * @readonly
+     */
+    private ComposerJsonFactory $composerJsonFactory;
+
     /**
      * @param iterable<ComposerJsonFractorRule> $rules
      */
-    public function __construct(
-        private iterable $rules,
-        private ComposerJsonPrinter $composerJsonPrinter,
-        private ComposerJsonFactory $composerJsonFactory
-    ) {
+    public function __construct(iterable $rules, ComposerJsonPrinter $composerJsonPrinter, ComposerJsonFactory $composerJsonFactory)
+    {
+        $this->rules = $rules;
+        $this->composerJsonPrinter = $composerJsonPrinter;
+        $this->composerJsonFactory = $composerJsonFactory;
     }
 
     public function handle(File $file, iterable $appliedRules): void

packages/fractor-composer-json/src/ErgebnisComposerJsonPrinter.php

@@ -9,11 +9,16 @@
 use a9f\FractorComposerJson\Contract\ComposerJsonPrinter;
 use Ergebnis\Json\Printer\PrinterInterface;
 
-final readonly class ErgebnisComposerJsonPrinter implements ComposerJsonPrinter
+final class ErgebnisComposerJsonPrinter implements ComposerJsonPrinter
 {
-    public function __construct(
-        private PrinterInterface $printer
-    ) {
+    /**
+     * @readonly
+     */
+    private PrinterInterface $printer;
+
+    public function __construct(PrinterInterface $printer)
+    {
+        $this->printer = $printer;
     }
 
     public function printToString(Indent $indent, ComposerJson $composerJson): string

packages/fractor-composer-json/src/ValueObject/EtaOrionisComposerJson.php

@@ -7,11 +7,16 @@
 use a9f\Fractor\Application\ValueObject\File;
 use a9f\FractorComposerJson\Contract\ComposerJson;
 
-final readonly class EtaOrionisComposerJson implements ComposerJson
+final class EtaOrionisComposerJson implements ComposerJson
 {
-    public function __construct(
-        private \EtaOrionis\ComposerJsonManipulator\ComposerJson $composerJson
-    ) {
+    /**
+     * @readonly
+     */
+    private \EtaOrionis\ComposerJsonManipulator\ComposerJson $composerJson;
+
+    public function __construct(\EtaOrionis\ComposerJsonManipulator\ComposerJson $composerJson)
+    {
+        $this->composerJson = $composerJson;
     }
 
     public static function fromFile(File $file): self

packages/fractor-composer-json/src/ValueObject/PackageAndVersion.php

@@ -4,12 +4,22 @@
 
 namespace a9f\FractorComposerJson\ValueObject;
 
-final readonly class PackageAndVersion
+final class PackageAndVersion
 {
-    public function __construct(
-        private string $packageName,
-        private string $version
-    ) {
+    /**
+     * @readonly
+     */
+    private string $packageName;
+
+    /**
+     * @readonly
+     */
+    private string $version;
+
+    public function __construct(string $packageName, string $version)
+    {
+        $this->packageName = $packageName;
+        $this->version = $version;
     }
 
     public function getPackageName(): string

packages/fractor-composer-json/src/ValueObject/RenamePackage.php

@@ -4,12 +4,22 @@
 
 namespace a9f\FractorComposerJson\ValueObject;
 
-final readonly class RenamePackage
+final class RenamePackage
 {
-    public function __construct(
-        private string $oldPackageName,
-        private string $newPackageName
-    ) {
+    /**
+     * @readonly
+     */
+    private string $oldPackageName;
+
+    /**
+     * @readonly
+     */
+    private string $newPackageName;
+
+    public function __construct(string $oldPackageName, string $newPackageName)
+    {
+        $this->oldPackageName = $oldPackageName;
+        $this->newPackageName = $newPackageName;
     }
 
     public function getOldPackageName(): string

packages/fractor-composer-json/src/ValueObject/ReplacePackageAndVersion.php

@@ -7,17 +7,29 @@
 use a9f\FractorComposerJson\ChangePackageVersionComposerJsonFractor;
 use Webmozart\Assert\Assert;
 
-final readonly class ReplacePackageAndVersion
+final class ReplacePackageAndVersion
 {
+    /**
+     * @readonly
+     */
+    private string $version;
+
+    /**
+     * @readonly
+     */
     private string $oldPackageName;
 
+    /**
+     * @readonly
+     */
     private string $newPackageName;
 
     public function __construct(
         string $oldPackageName,
         string $newPackageName,
-        private string $version
+        string $version
     ) {
+        $this->version = $version;
         Assert::notSame(
             $oldPackageName,
             $newPackageName,

packages/fractor-fluid/src/FluidFileProcessor.php

@@ -12,14 +12,20 @@
 /**
  * @implements FileProcessor<FluidFractorRule>
  */
-final readonly class FluidFileProcessor implements FileProcessor
+final class FluidFileProcessor implements FileProcessor
 {
+    /**
+     * @var iterable<FluidFractorRule>
+     * @readonly
+     */
+    private iterable $rules;
+
     /**
      * @param iterable<FluidFractorRule> $rules
      */
-    public function __construct(
-        private iterable $rules
-    ) {
+    public function __construct(iterable $rules)
+    {
+        $this->rules = $rules;
     }
 
     public function canHandle(File $file): bool

packages/fractor-phpstan-rules/src/Rules/AddChangelogDocBlockForFractorRule.php

@@ -18,17 +18,27 @@
 /**
  * @implements Rule<Class_>
  */
-final readonly class AddChangelogDocBlockForFractorRule implements Rule
+final class AddChangelogDocBlockForFractorRule implements Rule
 {
     /**
      * @var string
      */
     public const ERROR_MESSAGE = 'Provide @changelog doc block for "%s" Fractor rule';
 
-    public function __construct(
-        private ReflectionProvider $reflectionProvider,
-        private FileTypeMapper $fileTypeMapper
-    ) {
+    /**
+     * @readonly
+     */
+    private ReflectionProvider $reflectionProvider;
+
+    /**
+     * @readonly
+     */
+    private FileTypeMapper $fileTypeMapper;
+
+    public function __construct(ReflectionProvider $reflectionProvider, FileTypeMapper $fileTypeMapper)
+    {
+        $this->reflectionProvider = $reflectionProvider;
+        $this->fileTypeMapper = $fileTypeMapper;
     }
 
     public function getNodeType(): string
@@ -84,7 +94,7 @@ public function processNode(Node $node, Scope $scope): array
         );
 
         $phpDocString = $resolvedPhpDoc->getPhpDocString();
-        if (\str_contains($phpDocString, '@changelog')) {
+        if (strpos($phpDocString, '@changelog') !== false) {
             return [];
         }
 

packages/fractor-typoscript/src/AbstractTypoScriptFractor.php

@@ -26,7 +26,7 @@ final public function beforeTraversal(File $file, array $statements): void
     /**
      * @return Statement|list<Statement>|int
      */
-    final public function enterNode(Statement $node): Statement|array|int
+    final public function enterNode(Statement $node)
     {
         $result = $this->refactor($node);
 

packages/fractor-typoscript/src/Contract/TypoScriptFractor.php

@@ -9,5 +9,8 @@
 
 interface TypoScriptFractor extends FractorRule, TypoScriptNodeVisitor
 {
-    public function refactor(Statement $statement): null|Statement|int;
+    /**
+     * @return null|Statement|int
+     */
+    public function refactor(Statement $statement);
 }

packages/fractor-typoscript/src/Contract/TypoScriptNodeVisitor.php

@@ -21,7 +21,7 @@ public function beforeTraversal(File $file, array $statements): void;
     /**
      * @return Statement|list<Statement>|TypoScriptStatementsIterator::*
      */
-    public function enterNode(Statement $node): Statement|array|int;
+    public function enterNode(Statement $node);
 
     public function leaveNode(Statement $node): void;
 

packages/fractor-typoscript/src/TypoScriptFileProcessor.php

@@ -18,20 +18,54 @@
 /**
  * @implements FileProcessor<TypoScriptFractor>
  */
-final readonly class TypoScriptFileProcessor implements FileProcessor
+final class TypoScriptFileProcessor implements FileProcessor
 {
+    /**
+     * @var iterable<TypoScriptFractor>
+     * @readonly
+     */
+    private iterable $rules;
+
+    /**
+     * @readonly
+     */
+    private Parser $parser;
+
+    /**
+     * @readonly
+     */
+    private PrettyPrinter $printer;
+
+    /**
+     * @readonly
+     */
+    private PrettyPrinterConfigurationFactory $prettyPrinterConfigurationFactory;
+
+    /**
+     * @readonly
+     */
+    private TypoScriptPrettyPrinterFormatConfiguration $typoScriptPrettyPrinterFormatConfiguration;
+
+    /**
+     * @readonly
+     */
     private BufferedOutput $output;
 
     /**
      * @param iterable<TypoScriptFractor> $rules
      */
     public function __construct(
-        private iterable $rules,
-        private Parser $parser,
-        private PrettyPrinter $printer,
-        private PrettyPrinterConfigurationFactory $prettyPrinterConfigurationFactory,
-        private TypoScriptPrettyPrinterFormatConfiguration $typoScriptPrettyPrinterFormatConfiguration
+        iterable $rules,
+        Parser $parser,
+        PrettyPrinter $printer,
+        PrettyPrinterConfigurationFactory $prettyPrinterConfigurationFactory,
+        TypoScriptPrettyPrinterFormatConfiguration $typoScriptPrettyPrinterFormatConfiguration
     ) {
+        $this->rules = $rules;
+        $this->parser = $parser;
+        $this->printer = $printer;
+        $this->prettyPrinterConfigurationFactory = $prettyPrinterConfigurationFactory;
+        $this->typoScriptPrettyPrinterFormatConfiguration = $typoScriptPrettyPrinterFormatConfiguration;
         $this->output = new BufferedOutput();
     }
 
@@ -59,9 +93,9 @@ public function handle(File $file, iterable $appliedRules): void
             $newTypoScriptContent = $this->output->fetch();
             $typoScriptContent = rtrim($newTypoScriptContent) . "\n";
             $file->changeFileContent($typoScriptContent);
-        } catch (TokenizerException) {
+        } catch (TokenizerException $exception) {
             return;
-        } catch (ParseError) {
+        } catch (ParseError $exception) {
         }
     }
 

packages/fractor-typoscript/src/TypoScriptStatementsIterator.php

@@ -11,7 +11,7 @@
 use Helmich\TypoScriptParser\Parser\AST\Statement;
 use Webmozart\Assert\Assert;
 
-final readonly class TypoScriptStatementsIterator
+final class TypoScriptStatementsIterator
 {
     /**
      * @var int
@@ -20,6 +20,7 @@
 
     /**
      * @var array<TypoScriptNodeVisitor>
+     * @readonly
      */
     private iterable $visitors;
 
@@ -75,7 +76,7 @@ private function processStatementList(array $statements): array
     /**
      * @return self::*|Statement|list<Statement>
      */
-    private function traverseNode(Statement $node): int|Statement|array
+    private function traverseNode(Statement $node)
     {
         $lastCalledVisitor = null;
         $result = $node;