Update fireball system #474
Conversation
|
Is this still available? |
Yep! I am still getting messages from people about this issue being existential |
|
I heard that the current implementation caused issues with certain addons so it would be good to have this implemented, but it should be tested before release. |
|
@tomkeuper did you test it? |
|
No I havent tested it. I was planning on making a build with this included when the 23.2.2 version is released. So poeple can test it before we merge it completely. |
MherZaqaryan
temporarily deployed
to
development
GitHub Actions
Inactive
|
@MherZaqaryan Could you merge the latest commits? I would like to test this the comming weeks |
MherZaqaryan
dismissed stale reviews from andrei1058 and tomkeuper
via
58cba4a
|
Why this isn't merged? |
|
I see |
Sorry, I misread. This was actually not implemented |
|
-_- seriously?.. |
Yes, this PR is to fix the bug in the Cosmetics addon. In this PR, a check of arena.getStatus() != GameState.playing is performed for fireball damage, cancelling the fireball damage after the game ends. In the current version, this has not been implemented. |
It's better to keep the fireball listers in one listener class file and also add a check which will check if the game has a playing status because in some cases addons' custom fireballs are being handled by these events and there is no way to prevent it.