Skip to content

Commit

Permalink
Protect against priors for parameters that are not sampled
Browse files Browse the repository at this point in the history
  • Loading branch information
andreicuceu committed Feb 6, 2024
1 parent 7106d34 commit ebb5ba9
Showing 1 changed file with 12 additions and 9 deletions.
21 changes: 12 additions & 9 deletions vega/vega_interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,6 @@ def __init__(self, main_path):
'beta_QSO' in self.sample_params['limits']):
print('WARNING! Running on blind data and sampling bias_QSO and beta_QSO.')

# Get priors
self.priors = {}
if 'priors' in self.main_config:
self.priors = self._init_priors(self.main_config['priors'])
for param in self.priors.keys():
if param not in self.sample_params['limits'].keys():
print('Warning: Prior specified for a parameter that is'
' not sampled!')

# Read the monte carlo parameters
self.mc_config = None
if 'monte carlo' in self.main_config:
Expand All @@ -155,6 +146,18 @@ def __init__(self, main_path):

self.mc_config['sample'] = self._read_sample(config)

# Get priors
self.priors = {}
if 'priors' in self.main_config:
self.priors = self._init_priors(self.main_config['priors'])
for param in self.priors.keys():
param_is_not_sampled = param not in self.sample_params['limits']
if self.mc_config is not None:
param_is_not_sampled &= param not in self.mc_config['sample']['limits']
if param_is_not_sampled:
raise ValueError(
f'Prior specified for a parameter that is not sampled: {param}')

# Read the global covariance
if global_cov_file is not None:
self.read_global_cov(global_cov_file)
Expand Down

0 comments on commit ebb5ba9

Please sign in to comment.