Fixed #231 - disableRightClick doesn't. Thanks to @DrMint for the fix

andreknieriem · Apr 14, 2021 · 5b19221 · 5b19221
1 parent 95ea8ad
commit 5b19221
Show file tree

Hide file tree

Showing 15 changed files with 20 additions and 19 deletions.
diff --git a/README.md b/README.md
@@ -220,6 +220,7 @@ Run `gulp watch` to enable continous watching of both src/simple-lightbox.js and
 Just call `gulp build` to have all files and variants created inside dist!
 
 ### Changelog
+**2.7.2 - Fixed #231 - disableRightClick doesn't. Thanks to @DrMint for the fix**  
 **2.7.1 - Fixed #228 - no mouse swiping in firefox. Thanks to @DrMint for the fix**  
 **2.7.0 - Merged #206 which fixes #205. Thanks to @ocean90 for the idea and PR**  
 **2.6.0 - Added new option uniqueImages for #156, focus for #190 and fixed bug #200 issue closing during animation**  

diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "simplelightbox",
-  "version": "2.7.1",
+  "version": "2.7.2",
   "homepage": "https://simplelightbox.com/",
   "authors": [
     "André Rinas <info@andrerinas.de> (https://www.andrerinas.de)"

diff --git a/dist/simple-lightbox.css b/dist/simple-lightbox.css
@@ -2,7 +2,7 @@
 	By André Rinas, www.andrerinas.de
 	Documentation, www.simplelightbox.de
 	Available for use under the MIT License
-	Version 2.7.1
+	Version 2.7.2
 */
 body.hidden-scroll {
   overflow: hidden; }

diff --git a/dist/simple-lightbox.esm.js b/dist/simple-lightbox.esm.js
@@ -2,7 +2,7 @@
 	By André Rinas, www.andrerinas.de
 	Documentation, www.simplelightbox.de
 	Available for use under the MIT License
-	Version 2.7.1
+	Version 2.7.2
 */
 class SimpleLightbox {
 
@@ -201,7 +201,7 @@ class SimpleLightbox {
         // disable rightclick
         if (this.options.disableRightClick) {
             this.addEventListener(document.body, 'contextmenu.' + this.eventNamespace, (event) => {
-                if (event.target.classList.contains('sl-overlay')) {
+                if (event.target.parentElement.classList.contains("sl-image")) {
                     event.preventDefault();
                 }
             });

diff --git a/dist/simple-lightbox.jquery.js b/dist/simple-lightbox.jquery.js
@@ -2,7 +2,7 @@
 	By André Rinas, www.andrerinas.de
 	Documentation, www.simplelightbox.de
 	Available for use under the MIT License
-	Version 2.7.1
+	Version 2.7.2
 */
 (function(){function r(e,n,t){function o(i,f){if(!n[i]){if(!e[i]){var c="function"==typeof require&&require;if(!f&&c)return c(i,!0);if(u)return u(i,!0);var a=new Error("Cannot find module '"+i+"'");throw a.code="MODULE_NOT_FOUND",a}var p=n[i]={exports:{}};e[i][0].call(p.exports,function(r){var n=e[i][1][r];return o(n||r)},p,p.exports,r,e,n,t)}return n[i].exports}for(var u="function"==typeof require&&require,i=0;i<t.length;i++)o(t[i]);return o}return r})()({1:[function(require,module,exports){
 "use strict";
@@ -249,7 +249,7 @@ var SimpleLightbox = /*#__PURE__*/function () {
 
     if (this.options.disableRightClick) {
       this.addEventListener(document.body, 'contextmenu.' + this.eventNamespace, function (event) {
-        if (event.target.classList.contains('sl-overlay')) {
+        if (event.target.parentElement.classList.contains("sl-image")) {
           event.preventDefault();
         }
       });

diff --git a/dist/simple-lightbox.jquery.min.js b/dist/simple-lightbox.jquery.min.js
diff --git a/dist/simple-lightbox.js b/dist/simple-lightbox.js
@@ -2,7 +2,7 @@
 	By André Rinas, www.andrerinas.de
 	Documentation, www.simplelightbox.de
 	Available for use under the MIT License
-	Version 2.7.1
+	Version 2.7.2
 */
 (function(){function r(e,n,t){function o(i,f){if(!n[i]){if(!e[i]){var c="function"==typeof require&&require;if(!f&&c)return c(i,!0);if(u)return u(i,!0);var a=new Error("Cannot find module '"+i+"'");throw a.code="MODULE_NOT_FOUND",a}var p=n[i]={exports:{}};e[i][0].call(p.exports,function(r){var n=e[i][1][r];return o(n||r)},p,p.exports,r,e,n,t)}return n[i].exports}for(var u="function"==typeof require&&require,i=0;i<t.length;i++)o(t[i]);return o}return r})()({1:[function(require,module,exports){
 (function (global){(function (){
@@ -236,7 +236,7 @@ var SimpleLightbox = /*#__PURE__*/function () {
 
     if (this.options.disableRightClick) {
       this.addEventListener(document.body, 'contextmenu.' + this.eventNamespace, function (event) {
-        if (event.target.classList.contains('sl-overlay')) {
+        if (event.target.parentElement.classList.contains("sl-image")) {
           event.preventDefault();
         }
       });

diff --git a/dist/simple-lightbox.legacy.js b/dist/simple-lightbox.legacy.js
@@ -2,7 +2,7 @@
 	By André Rinas, www.andrerinas.de
 	Documentation, www.simplelightbox.de
 	Available for use under the MIT License
-	Version 2.7.1
+	Version 2.7.2
 */
 (function(){function r(e,n,t){function o(i,f){if(!n[i]){if(!e[i]){var c="function"==typeof require&&require;if(!f&&c)return c(i,!0);if(u)return u(i,!0);var a=new Error("Cannot find module '"+i+"'");throw a.code="MODULE_NOT_FOUND",a}var p=n[i]={exports:{}};e[i][0].call(p.exports,function(r){var n=e[i][1][r];return o(n||r)},p,p.exports,r,e,n,t)}return n[i].exports}for(var u="function"==typeof require&&require,i=0;i<t.length;i++)o(t[i]);return o}return r})()({1:[function(require,module,exports){
 require('../modules/es.symbol');
@@ -12303,7 +12303,7 @@ var SimpleLightbox = /*#__PURE__*/function () {
 
     if (this.options.disableRightClick) {
       this.addEventListener(document.body, 'contextmenu.' + this.eventNamespace, function (event) {
-        if (event.target.classList.contains('sl-overlay')) {
+        if (event.target.parentElement.classList.contains("sl-image")) {
           event.preventDefault();
         }
       });

diff --git a/dist/simple-lightbox.legacy.min.js b/dist/simple-lightbox.legacy.min.js
diff --git a/dist/simple-lightbox.min.css b/dist/simple-lightbox.min.css
diff --git a/dist/simple-lightbox.min.js b/dist/simple-lightbox.min.js
diff --git a/dist/simple-lightbox.modules.js b/dist/simple-lightbox.modules.js
@@ -2,7 +2,7 @@
 	By André Rinas, www.andrerinas.de
 	Documentation, www.simplelightbox.de
 	Available for use under the MIT License
-	Version 2.7.1
+	Version 2.7.2
 */
 "use strict";
 
@@ -234,7 +234,7 @@ var SimpleLightbox = /*#__PURE__*/function () {
 
     if (this.options.disableRightClick) {
       this.addEventListener(document.body, 'contextmenu.' + this.eventNamespace, function (event) {
-        if (event.target.classList.contains('sl-overlay')) {
+        if (event.target.parentElement.classList.contains("sl-image")) {
           event.preventDefault();
         }
       });

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "simplelightbox",
-  "version": "2.7.1",
+  "version": "2.7.2",
   "description": "Touch-friendly modern image lightbox for mobile and desktop with optional jQuery support",
   "main": "dist/simple-lightbox.js",
   "style": "dist/simple-lightbox.css",

diff --git a/src/license-notice.txt b/src/license-notice.txt
@@ -2,5 +2,5 @@
 	By André Rinas, www.andrerinas.de
 	Documentation, www.simplelightbox.de
 	Available for use under the MIT License
-	Version 2.7.1
+	Version 2.7.2
 */
diff --git a/src/simple-lightbox.js b/src/simple-lightbox.js
@@ -195,7 +195,7 @@ class SimpleLightbox {
         // disable rightclick
         if (this.options.disableRightClick) {
             this.addEventListener(document.body, 'contextmenu.' + this.eventNamespace, (event) => {
-                if (event.target.classList.contains('sl-overlay')) {
+                if (event.target.parentElement.classList.contains("sl-image")) {
                     event.preventDefault();
                 }
             });