Fixed #228 - no mouse swiping in firefox. Thanks to @DrMint for the fix

andreknieriem · Apr 13, 2021 · d56606d · d56606d
1 parent d277da6
commit d56606d
Show file tree

Hide file tree

Showing 16 changed files with 32 additions and 16 deletions.
diff --git a/README.md b/README.md
@@ -220,6 +220,7 @@ Run `gulp watch` to enable continous watching of both src/simple-lightbox.js and
 Just call `gulp build` to have all files and variants created inside dist!
 
 ### Changelog
+**2.7.1 - Fixed #228 - no mouse swiping in firefox. Thanks to @DrMint for the fix**  
 **2.7.0 - Merged #206 which fixes #205. Thanks to @ocean90 for the idea and PR**  
 **2.6.0 - Added new option uniqueImages for #156, focus for #190 and fixed bug #200 issue closing during animation**  
 **2.5.0 - Added new option fadeSpeed. This will fix #147 and #186**  
@@ -305,3 +306,4 @@ Just call `gulp build` to have all files and variants created inside dist!
 [Jochen Sengier](https://www.celcius.be) - [Github](https://github.com/celcius-jochen/)  
 [Dmytro Hrynevych](https://github.com/dmh)  
 [Dominik Schilling](https://dominikschilling.de/) - [Github](https://github.com/ocean90/)  
+[DrMint](https://github.com/DrMint)  
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "simplelightbox",
-  "version": "2.7.0",
+  "version": "2.7.1",
   "homepage": "https://simplelightbox.com/",
   "authors": [
     "André Rinas <info@andrerinas.de> (https://www.andrerinas.de)"

diff --git a/demo/index.html b/demo/index.html
@@ -4,7 +4,7 @@
 <meta charset="utf-8">
 <meta content="width=device-width, initial-scale=1, maximum-scale=1, user-scalable=no" name="viewport" />
 <link href="https://fonts.googleapis.com/css?family=Raleway:300,400,700" rel="stylesheet">
-<link rel="stylesheet" href="../dist/simple-lightbox.css?v2.7.0" />
+<link rel="stylesheet" href="../dist/simple-lightbox.css?v2.7.1" />
 <link rel="stylesheet" href="demo.css" />
 <title>SimpleLightbox by André Rinas</title>
 </head>
@@ -14,7 +14,7 @@
 	<div class="header-container">
 		<div class="container demo-container">
 			<div class="info">
-				<h1>SimpleLightbox <sup>v2.7.0</sup></h1>
+				<h1>SimpleLightbox <sup>v2.7.1</sup></h1>
 				<span class="subline">Touch-friendly image lightbox</span>
 				<nav>
 					<a class="btn donate" target="_blank" href="https://www.paypal.me/anrinas">Donate</a>
@@ -621,6 +621,7 @@ <h2>Customization</h2>
 				<h2>Changelog</h2>
 			</div>
 			<div class="col-right">
+				<strong>2.7.1</strong> - Fixed #228 - no mouse swiping in firefox. Thanks to @DrMint for the fix<br />
 				<strong>2.7.0</strong> - Merged #206 which fixes #205. Thanks to @ocean90 for the idea and PR<br />
 				<strong>2.6.0</strong> - Added new option uniqueImages for #156, focus for #190 and fixed bug #200 issue closing during animation.<br />
 				<strong>2.5.0</strong> - Added new option fadeSpeed. This will fix #147.<br />
@@ -715,6 +716,7 @@ <h2>Author/<br />Contributors</h2>
 					<a target="_blank" href="https://www.celcius.be">Jochen Sengier</a> - <a target="_blank" href="https://github.com/celcius-jochen/">Github</a><br>
 					<a target="_blank" href="https://github.com/dmh">Dmytro Hrynevych</a><br>
 					<a target="_blank" href="https://dominikschilling.de/">Dominik Schilling</a>  - <a target="_blank" href="https://github.com/ocean90/">Github</a><br>
+					<a target="_blank" href="https://github.com/DrMint">DrMint</a><br>
 				</p>
 			</div>
 		</div>
@@ -726,7 +728,7 @@ <h2>Author/<br />Contributors</h2>
 	</div>
 </footer>
 <script src="https://code.jquery.com/jquery-3.5.1.min.js" integrity="sha256-9/aliU8dGd2tb6OSsuzixeV4y/faTqgFtohetphbbj0=" crossorigin="anonymous"></script>
-<script src="../dist/simple-lightbox.js?v2.7.0"></script>
+<script src="../dist/simple-lightbox.js?v2.7.1"></script>
 <script>
 	(function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
 	(i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),

diff --git a/dist/simple-lightbox.css b/dist/simple-lightbox.css
@@ -2,7 +2,7 @@
 	By André Rinas, www.andrerinas.de
 	Documentation, www.simplelightbox.de
 	Available for use under the MIT License
-	Version 2.7.0
+	Version 2.7.1
 */
 body.hidden-scroll {
   overflow: hidden; }

diff --git a/dist/simple-lightbox.esm.js b/dist/simple-lightbox.esm.js
@@ -2,7 +2,7 @@
 	By André Rinas, www.andrerinas.de
 	Documentation, www.simplelightbox.de
 	Available for use under the MIT License
-	Version 2.7.0
+	Version 2.7.1
 */
 class SimpleLightbox {
 
@@ -688,6 +688,8 @@ class SimpleLightbox {
                 return true;
             }
 
+            event.preventDefault();
+
             if (event.type === 'mousedown') {
                 this.controlCoordinates.initialPointerOffsetX = event.clientX;
                 this.controlCoordinates.initialPointerOffsetY = event.clientY;

diff --git a/dist/simple-lightbox.jquery.js b/dist/simple-lightbox.jquery.js
@@ -2,7 +2,7 @@
 	By André Rinas, www.andrerinas.de
 	Documentation, www.simplelightbox.de
 	Available for use under the MIT License
-	Version 2.7.0
+	Version 2.7.1
 */
 (function(){function r(e,n,t){function o(i,f){if(!n[i]){if(!e[i]){var c="function"==typeof require&&require;if(!f&&c)return c(i,!0);if(u)return u(i,!0);var a=new Error("Cannot find module '"+i+"'");throw a.code="MODULE_NOT_FOUND",a}var p=n[i]={exports:{}};e[i][0].call(p.exports,function(r){var n=e[i][1][r];return o(n||r)},p,p.exports,r,e,n,t)}return n[i].exports}for(var u="function"==typeof require&&require,i=0;i<t.length;i++)o(t[i]);return o}return r})()({1:[function(require,module,exports){
 "use strict";
@@ -748,6 +748,8 @@ var SimpleLightbox = /*#__PURE__*/function () {
           return true;
         }
 
+        event.preventDefault();
+
         if (event.type === 'mousedown') {
           _this6.controlCoordinates.initialPointerOffsetX = event.clientX;
           _this6.controlCoordinates.initialPointerOffsetY = event.clientY;

diff --git a/dist/simple-lightbox.jquery.min.js b/dist/simple-lightbox.jquery.min.js
diff --git a/dist/simple-lightbox.js b/dist/simple-lightbox.js
@@ -2,7 +2,7 @@
 	By André Rinas, www.andrerinas.de
 	Documentation, www.simplelightbox.de
 	Available for use under the MIT License
-	Version 2.7.0
+	Version 2.7.1
 */
 (function(){function r(e,n,t){function o(i,f){if(!n[i]){if(!e[i]){var c="function"==typeof require&&require;if(!f&&c)return c(i,!0);if(u)return u(i,!0);var a=new Error("Cannot find module '"+i+"'");throw a.code="MODULE_NOT_FOUND",a}var p=n[i]={exports:{}};e[i][0].call(p.exports,function(r){var n=e[i][1][r];return o(n||r)},p,p.exports,r,e,n,t)}return n[i].exports}for(var u="function"==typeof require&&require,i=0;i<t.length;i++)o(t[i]);return o}return r})()({1:[function(require,module,exports){
 (function (global){(function (){
@@ -735,6 +735,8 @@ var SimpleLightbox = /*#__PURE__*/function () {
           return true;
         }
 
+        event.preventDefault();
+
         if (event.type === 'mousedown') {
           _this6.controlCoordinates.initialPointerOffsetX = event.clientX;
           _this6.controlCoordinates.initialPointerOffsetY = event.clientY;

diff --git a/dist/simple-lightbox.legacy.js b/dist/simple-lightbox.legacy.js
@@ -2,7 +2,7 @@
 	By André Rinas, www.andrerinas.de
 	Documentation, www.simplelightbox.de
 	Available for use under the MIT License
-	Version 2.7.0
+	Version 2.7.1
 */
 (function(){function r(e,n,t){function o(i,f){if(!n[i]){if(!e[i]){var c="function"==typeof require&&require;if(!f&&c)return c(i,!0);if(u)return u(i,!0);var a=new Error("Cannot find module '"+i+"'");throw a.code="MODULE_NOT_FOUND",a}var p=n[i]={exports:{}};e[i][0].call(p.exports,function(r){var n=e[i][1][r];return o(n||r)},p,p.exports,r,e,n,t)}return n[i].exports}for(var u="function"==typeof require&&require,i=0;i<t.length;i++)o(t[i]);return o}return r})()({1:[function(require,module,exports){
 require('../modules/es.symbol');
@@ -12802,6 +12802,8 @@ var SimpleLightbox = /*#__PURE__*/function () {
           return true;
         }
 
+        event.preventDefault();
+
         if (event.type === 'mousedown') {
           _this6.controlCoordinates.initialPointerOffsetX = event.clientX;
           _this6.controlCoordinates.initialPointerOffsetY = event.clientY;

diff --git a/dist/simple-lightbox.legacy.min.js b/dist/simple-lightbox.legacy.min.js
diff --git a/dist/simple-lightbox.min.css b/dist/simple-lightbox.min.css
diff --git a/dist/simple-lightbox.min.js b/dist/simple-lightbox.min.js
diff --git a/dist/simple-lightbox.modules.js b/dist/simple-lightbox.modules.js
@@ -2,7 +2,7 @@
 	By André Rinas, www.andrerinas.de
 	Documentation, www.simplelightbox.de
 	Available for use under the MIT License
-	Version 2.7.0
+	Version 2.7.1
 */
 "use strict";
 
@@ -733,6 +733,8 @@ var SimpleLightbox = /*#__PURE__*/function () {
           return true;
         }
 
+        event.preventDefault();
+
         if (event.type === 'mousedown') {
           _this6.controlCoordinates.initialPointerOffsetX = event.clientX;
           _this6.controlCoordinates.initialPointerOffsetY = event.clientY;

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "simplelightbox",
-  "version": "2.7.0",
+  "version": "2.7.1",
   "description": "Touch-friendly modern image lightbox for mobile and desktop with optional jQuery support",
   "main": "dist/simple-lightbox.js",
   "style": "dist/simple-lightbox.css",

diff --git a/src/license-notice.txt b/src/license-notice.txt
@@ -2,5 +2,5 @@
 	By André Rinas, www.andrerinas.de
 	Documentation, www.simplelightbox.de
 	Available for use under the MIT License
-	Version 2.7.0
+	Version 2.7.1
 */
diff --git a/src/simple-lightbox.js b/src/simple-lightbox.js
@@ -682,6 +682,8 @@ class SimpleLightbox {
                 return true;
             }
 
+            event.preventDefault();
+
             if (event.type === 'mousedown') {
                 this.controlCoordinates.initialPointerOffsetX = event.clientX;
                 this.controlCoordinates.initialPointerOffsetY = event.clientY;