GH Linting Improvements #1272
GH Linting Improvements #1272
Conversation
bmos
commented
Mar 9, 2024
•
bmos
commented
- JSON validation was being run when other actions were modified, no longer does
- Added python 3.12 to linting version matrix to watch for use of deprecated syntax and methods
- Remove branch filter from linting workflow (so it lints any forks and PRs)
- Use ruff command line flags to export results as SARIF file and upload to GitHub CodeQL
- Requirements.txt uses ">=X, <X" syntx to allow future minor+patch updates but not future major versions (except to homeassistant)
- Use uv for installing requirements in linting action to reduce runtime
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
I have tested these actions on a fork and they should be ready for merging. |
|
Thanks for these improvements, actions I'm slowly stumbling my way around and knew there was more that could be improved but it's a distraction from the real code so never gets a high priority. |
|
I think your priorities are well-chosen, the new Battery Stats features and the translations getting built out are very cool! |
* updated ruff config syntax * don't validate json when other actions are updated * efficient linting + 3.12 * integrate ruff with github code ql * use more permissive versions in requirements * add trigger on schema * update softprops/action-gh-release
