Improve API for Tab Preference Selection #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace Settings.alwaysDisplayTabsMode(Dockable) and Settings.setAlwaysDisplayTabMode with Settings.defaultTabPreference and Settings.setDefaultTabPreference. This new setting makes it possible to specify tab location preference as top or bottom. It also makes it possible to always display tabs by using DockableTabPreference.TOP_ALWAYS and DockableTabPreference.BOTTOM_ALWAYS. The Dockable.getTabPosition method has been replaced with Dockable.getTabPreference, which now returns an instance of DockableTabPreference and returns NONE by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Settings.alwaysDisplayTabsMode(Dockable) and Settings.setAlwaysDisplayTabMode with Settings.defaultTabPreference and Settings.setDefaultTabPreference.
This new setting makes it possible to specify tab location preference as top or bottom. It also makes it possible to always display tabs by using DockableTabPreference.TOP_ALWAYS and DockableTabPreference.BOTTOM_ALWAYS.
The Dockable.getTabPosition method has been replaced with Dockable.getTabPreference, which now returns an instance of DockableTabPreference and returns NONE by default.