more typing

pint/_typing.py

@@ -48,5 +48,10 @@
 
 
 class Handler(Protocol):
+    @overload
+    def __getitem__(self, Never, /) -> Never:
+        ...
+
+    @overload
     def __getitem__(self, item: type[T]) -> Callable[[T], None]:
         ...

pint/delegates/txt_defparser/defparser.py

@@ -68,7 +68,9 @@ class DefParser:
         plain.CommentDefinition,
     )
 
-    def __init__(self, default_config: ParserConfig, diskcache: fc.DiskCache) -> None:
+    def __init__(
+        self, default_config: ParserConfig, diskcache: fc.DiskCache | None
+    ) -> None:
         self._default_config = default_config
         self._diskcache = diskcache
 

pint/facets/nonmultiplicative/registry.py

@@ -94,6 +94,7 @@ def _add_unit(self, definition: UnitDefinition) -> None:
             "delta_" + alias for alias in definition.aliases
         )
 
+        assert isinstance(definition.reference, UnitsContainer)
         delta_reference = self.UnitsContainer(
             {ref: value for ref, value in definition.reference.items()}
         )
@@ -198,6 +199,7 @@ def _add_ref_of_log_or_offset_unit(
 
             # TODO: Check that reference is None
 
+            assert isinstance(slct_ref, UnitsContainer)
             # If reference unit is not dimensionless
             if slct_ref != UnitsContainer():
                 # Extract reference unit

pint/facets/plain/definitions.py

@@ -13,7 +13,7 @@
 import typing as ty
 from dataclasses import dataclass
 from functools import cached_property
-from typing import Any
+from typing import Any, no_type_check
 
 from ... import errors
 from ..._typing import Magnitude
@@ -121,7 +121,7 @@ class UnitDefinition(NamedDefinition, errors.WithDefErr):
     defined_symbol: str | None
     #: additional names for the same unit
     aliases: tuple[str, ...]
-    #: A functiont that converts a value in these units into the reference units
+    #: A function that converts a value in these units into the reference units
     # TODO: this has changed as converter is now annotated as converter.
     # Briefly, in several places converter attributes like as_multiplicative were
     # accesed. So having a generic function is a no go.
@@ -192,7 +192,7 @@ def is_base(self) -> bool:
         """Indicates if it is a base unit."""
 
         # TODO: This is set in __post_init__
-        return self._is_base
+        return self._is_base  # type: ignore[attr-defined]
 
     @property
     def is_multiplicative(self) -> bool:
@@ -283,8 +283,10 @@ def __post_init__(self):
 class ScaleConverter(Converter):
     """A linear transformation without offset."""
 
-    scale: float
+    scale: numbers.Number
 
+    # typing non_int_type related
+    @no_type_check
     def to_reference(self, value: Magnitude, inplace: bool = False) -> Magnitude:
         if inplace:
             value *= self.scale
@@ -293,6 +295,8 @@ def to_reference(self, value: Magnitude, inplace: bool = False) -> Magnitude:
 
         return value
 
+    # typing non_int_type related
+    @no_type_check
     def from_reference(self, value: Magnitude, inplace: bool = False) -> Magnitude:
         if inplace:
             value /= self.scale

pint/facets/plain/qto.py

@@ -4,7 +4,7 @@
 import math
 import numbers
 import warnings
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, no_type_check
 
 from ...compat import (
     mip_INF,
@@ -193,7 +193,7 @@ def to_preferred(
 
 def ito_preferred(
     quantity: PlainQuantity, preferred_units: list[UnitLike] | None = None
-) -> PlainQuantity:
+) -> None:
     """Return Quantity converted to a unit composed of the preferred units.
 
     Examples
@@ -211,9 +211,10 @@ def ito_preferred(
     return quantity.ito(units)
 
 
+@no_type_check
 def _get_preferred(
     quantity: PlainQuantity, preferred_units: list[UnitLike] | None = None
-) -> PlainQuantity:
+) -> UnitsContainer:
     if preferred_units is None:
         preferred_units = quantity._REGISTRY.default_preferred_units
 

pint/facets/plain/registry.py

@@ -647,7 +647,6 @@ def _build_cache(self, loaded_files=None) -> None:
 
                 except Exception as exc:
                     logger.warning(f"Could not resolve {unit_name}: {exc!r}")
-        return self._cache
 
     def get_name(self, name_or_alias: str, case_sensitive: bool | None = None) -> str:
         """Return the canonical name of a unit."""

pint/facets/system/definitions.py

@@ -57,6 +57,7 @@ def from_lines(
         for definition in parser.iter_parsed_project(pp):
             if isinstance(definition, cls):
                 return definition
+        return None
 
     @property
     def unit_replacements(self) -> tuple[tuple[str, str | None], ...]:

pint/facets/system/registry.py

@@ -18,7 +18,7 @@
 if TYPE_CHECKING:
     from ..._typing import Quantity, Unit
 
-from ..._typing import UnitLike
+from ..._typing import QuantityOrUnitLike, UnitLike
 from ...util import UnitsContainer as UnitsContainerT
 from ...util import (
     create_class_with_registry,
@@ -223,7 +223,7 @@ def _get_base_units(
         return base_factor, destination_units
 
     def get_compatible_units(
-        self, input_units: UnitsContainerT, group_or_system: str | None = None
+        self, input_units: QuantityOrUnitLike, group_or_system: str | None = None
     ) -> frozenset[Unit]:
         """ """
 
@@ -240,7 +240,7 @@ def get_compatible_units(
 
     def _get_compatible_units(
         self, input_units: UnitsContainerT, group_or_system: str | None = None
-    ) -> frozenset[Unit]:
+    ) -> frozenset[str]:
         if group_or_system and group_or_system in self._systems:
             members = self._systems[group_or_system].members
             # group_or_system has been handled by System

pyproject.toml

@@ -119,3 +119,4 @@ exclude = [
     "pint/default_en.txt",
     "pint/constants_en.txt",
 ]
+disable_error_code = "operator,override"