Skip to content

Packaging issues #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2025
Merged

Packaging issues #161

merged 3 commits into from
Apr 19, 2025

Conversation

andrewhickman
Copy link
Owner

No description provided.

Copy link

codecov bot commented Apr 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.75%. Comparing base (cca111a) to head (cf92725).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   79.75%   79.75%           
=======================================
  Files          31       31           
  Lines        5250     5250           
=======================================
  Hits         4187     4187           
  Misses       1063     1063           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrewhickman andrewhickman merged commit 5467533 into main Apr 19, 2025
7 checks passed
@github-actions github-actions bot mentioned this pull request Apr 19, 2025
@SwishSwushPow
Copy link

Hi :) sorry to comment on this older PR, but I was wondering what reasons you had to include the tests with the published crate?

At my company we are trying to regularly review the crates we depend on whenever we update them to assure a baseline of supply chain safety. As part of that I just noticed that the tests showed up for prost-reflect. For our review process, this means that we have to check more files and LOC (which we don't like obviously 😁). We are aware that tests etc. can theoretically be run from the local .cargo directory, but we are not aware of many use cases that would need it. So we are keen to learn about possible use cases to maybe improve our review process and our understanding of how the supply chain can be made safer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants