wip

activesupport/lib/active_support/backtrace_cleaner.rb

@@ -44,7 +44,7 @@ def initialize
     # against it. Filters run first, then silencers.
     def clean(backtrace, kind = :silent)
       filtered = filter_backtrace(backtrace)
-
+      require "debug"; binding.b
       case kind
       when :silent
         silence(filtered)
@@ -66,9 +66,9 @@ def clean_frame(frame, kind = :silent)
 
       case kind
       when :silent
-        frame unless @silencers.any? { |s| s.call(frame) }
+        frame unless silencers.any? { |s| s.call(frame) }
       when :noise
-        frame if @silencers.any? { |s| s.call(frame) }
+        frame if silencers.any? { |s| s.call(frame) }
       else
         frame
       end
@@ -90,14 +90,14 @@ def add_filter(&block)
     #   # Will reject all lines that include the word "puma", like "/gems/puma/server.rb" or "/app/my_puma_server/rb"
     #   backtrace_cleaner.add_silencer { |line| /puma/.match?(line) }
     def add_silencer(&block)
-      @silencers << block
+      silencers << block
     end
 
     # Removes all silencers, but leaves in the filters. Useful if your
     # context of debugging suddenly expands as you suspect a bug in one of
     # the libraries you use.
     def remove_silencers!
-      @silencers = []
+      silencers = []
     end
 
     # Removes all filters, but leaves in the silencers. Useful if you suddenly
@@ -112,7 +112,7 @@ def remove_filters!
 
       def initialize_copy(_other)
         @filters = @filters.dup
-        @silencers = @silencers.dup
+        silencers = silencers.dup
       end
 
       def add_gem_filter
@@ -145,7 +145,7 @@ def filter_backtrace(backtrace)
       end
 
       def silence(backtrace)
-        @silencers.each do |s|
+        silencers.each do |s|
           backtrace = backtrace.reject { |line| s.call(line.to_s) }
         end
 
@@ -154,10 +154,15 @@ def silence(backtrace)
 
       def noise(backtrace)
         backtrace.select do |line|
-          @silencers.any? do |s|
+          silencers.any? do |s|
             s.call(line.to_s)
           end
         end
       end
+
+    def silencers
+      require "debug"; binding.b
+      @silencers
+    end
   end
 end

railties/lib/minitest/rails_plugin.rb

@@ -113,6 +113,7 @@ def self.plugin_rails_init(options)
       # Plugin can run without Rails loaded, check before filtering.
       if ::Rails.respond_to?(:backtrace_cleaner)
         Minitest.backtrace_filter = BacktraceFilterWithFallback.new(::Rails.backtrace_cleaner, Minitest.backtrace_filter)
+        require "debug"; binding.b
       end
     end
 

railties/lib/rails/application/bootstrap.rb

@@ -76,7 +76,10 @@ module Bootstrap
       end
 
       initializer :configure_backtrace_cleaner, group: :all do
-        Rails.backtrace_cleaner.remove_silencers! if ENV["BACKTRACE"]
+        config.after_initialize do
+          Rails.backtrace_cleaner.remove_silencers! if ENV["BACKTRACE"]
+          require "debug"; binding.b
+        end
       end
 
       # Initialize cache early in the stack so railties can make use of it.

railties/test/application/backtrace_cleaner_test.rb

@@ -27,6 +27,23 @@ def teardown
       assert_not_includes last_response.body, "rails/railties/test/env_helpers.rb"
     end
 
+    test "backtrace is cleaned with custom silencers" do
+      setup_app
+
+      app_file "config/initializers/backtrace_silencers.rb", <<-RUBY
+        Rails.backtrace_cleaner.add_silencer { |line| require "debug"; binding.b; line.include?("foo_controller.rb") }
+      RUBY
+
+      app("development")
+      get "/"
+      if RUBY_VERSION >= "3.4"
+        assert_not_includes last_response.body, "app/app/controllers/foo_controller.rb:4:in 'FooController#index'"
+      else
+        assert_not_includes last_response.body, "app/app/controllers/foo_controller.rb:4:in `index'"
+      end
+      assert_not_includes last_response.body, "rails/railties/test/env_helpers.rb"
+    end
+
     test "backtrace is not cleaned" do
       switch_env("BACKTRACE", "1") do
         setup_app
@@ -42,6 +59,25 @@ def teardown
       end
     end
 
+    test "custom silencers are not cleaned" do
+      switch_env("BACKTRACE", "1") do
+        setup_app
+
+        app_file "config/initializers/backtrace_silencers.rb", <<-RUBY
+          Rails.backtrace_cleaner.add_silencer { |line| line.include?("foo_controller.rb") }
+        RUBY
+
+        app("development")
+        get "/"
+        if RUBY_VERSION >= "3.4"
+          assert_includes last_response.body, "app/app/controllers/foo_controller.rb:4:in 'FooController#index'"
+        else
+          assert_includes last_response.body, "app/app/controllers/foo_controller.rb:4:in `index'"
+        end
+        assert_includes last_response.body, "rails/railties/test/env_helpers.rb"
+      end
+    end
+
     private
       def setup_app
         build_app