upgrade to flow-bin 0.95.1 and fix indent-string libdef #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrades to flow-bin 0.95.1, which includes an update to `JSON.stringify`. This update means `stringify` can return `string | undefined` (`undefined` is covered by a few edge cases). Flow does not accept `undefined` in string interpolations, so the string "undefined" has been used in these cases as a fix. `indent-string` changed its signature in 3.2.0. The updated libdef has been submitted to `flow-typed` and here we pull it down. Uses of the `indent` call have been fixed. It is suspected that the upgrade of Flow has increased type coverage here and flagged this as an error, because this should have otherwise gone undetected.
LoganBarnett
force-pushed
the
flow-0.95.1
branch
from
cb58d12 to
85c8d23
Compare
Author
|
The updated libdef was merged into |
Author
|
@andreypopp @Alxandr hey folks - is there anything I can do to help merge this PR? I've recently had to touch on some older work which is depending on a fork of this so it can use a more modern version of Flow. Thanks! |
Collaborator
|
Unfortunately I basically have no memory of this (nor use flow anymore) - so I'm probably not the right person to make any calls here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades to flow-bin 0.95.1, which includes an update to
JSON.stringify. This update meansstringifycan returnstring | undefined(undefinedis covered by a few edge cases). Flow does not acceptundefinedin string interpolations, so the string "undefined" has been used in these cases as a fix.indent-stringchanged its signature in 3.2.0. The updated libdef has been submitted toflow-typed(see flow-typed/flow-typed#3219) but until it is accepted the libdef has been copied here manually. Uses of theindentcall have been fixed. It is suspected that the upgrade of Flow has increased type coverage here and flagged this as an error, because this should have otherwise gone undetected.