Cleanup Gradle dependencies and miscellaneous improvements #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Inline versions that were used only once, allowing us to use the compact form for libraries & plugins - Merge TOML declarations with `group` + `name` into the unique `module` component - Expose new BoMs to enforce versioning across packages (`coil-kt-bom`, `kotlin-bom`, `kotlinx-coroutines-bom`, `kotlinx-serialization-bom`, `protobuf-bom`, `okhttp-bom`, `retrofit-bom`) - Refactor `jacoco` version declaration into a proper dependency declaration to enable actual dependency tracking - Rename `androidx.hilt.navigation.compose` to `hilt.ext.navigation.compose` to match the already existing `hiltExt` group. - Replace duplicated `*.gradlePlugin` dependencies with converter that converts plugin alias to usable dependencies. - Sort dependencies - Remove unused `kotlinx-coroutines-android` dependency
SimonMarquis
added a commit
to SimonMarquis/nowinandroid
that referenced
this pull request
Apr 5, 2025
- Use BOM platform dependency. - Remove -kt suffix from dependency name has they serve no real purpose. - Add `coil-network` artifact to configure `CallFactory`. - Although "First party Decoder" `SvgDecoder` is now automatically added to each new ImageLoader through a service loader, keeping it in code prevents us from removing the dependency that would appear unused otherwise. - Replace explicit `respectCacheHeaders(false)` with `CacheStrategy::DEFAULT` which does not respect cache-control headers. - Migrate `ImageLoaderFactory` to `SingletonImageLoader.Factory` - Inline TOML dependencies (see android#1856) docs: https://coil-kt.github.io/coil/upgrading_to_coil3/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
group+nameinto the uniquemodulecomponentcoil-kt-bom,kotlin-bom,kotlinx-coroutines-bom,kotlinx-serialization-bom,protobuf-bom,okhttp-bom,retrofit-bom)jacocoversion declaration into a proper dependency declaration to enable actual dependency trackingandroidx.hilt.navigation.composetohilt.ext.navigation.composeto match the already existinghiltExtgroup.*.gradlePlugindependencies with converter that converts plugin alias to usable dependencies.kotlinx-coroutines-androiddependency