Skip to content

Conversation

ybai001
Copy link
Contributor

@ybai001 ybai001 commented Oct 9, 2025

This PR adds Dolby Vision profile 10 (AV1 based) playback support.

Profile 10 includes profile 10.0 (not backward compatible), profile 10.1 (HDR10 compatible) and profile 10.4 (HLG compatible).

Merge latest code from upstream main branch
This PR adds Dolby Vision profile 10 (AV1 based) playback support.

Profile 10 includes profile 10.0 (not backward compatible), profile 10.1 (HDR10 compatible) and profile 10.4 (HLG compatible).
} else if (profile == CodecProfileLevel.DolbyVisionProfileDvav110) {
if (format.colorInfo != null
&& format.colorInfo.colorTransfer == C.COLOR_TRANSFER_ST2084
&& format.colorInfo.colorRange == C.COLOR_RANGE_FULL) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, it means this is a DV profile 10.0 content, which is not backward compatible to AV1 so that it cannot be played as AV1 content on non-Dolby licensed device.
Instead, DV profile 10.1 and 10.4 can be played as AV1 content on non-Dolby licensed device.
See more details on https://professionalsupport.dolby.com/s/article/What-is-Dolby-Vision-Profile?language=en_US, table 2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ybai001
Do DV profiles 10.1 and 10.4 not have these color space values? Or your solution is to only set these values for 10.0 and using that fact to make sure its not backwards compatible?

If other DV profiles have these color space values then its not a robust solution. What if in the future that information is generally parsed for all DolbyVision streams for some other purpose? Is there any other way to know the cross-compatibility id?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@microkatz, we actually set these values for other profiles here.

Let me provide more info about this code change.

Dolby Vision profile 10 includes profile 10.0, 10.1 and 10.4 currently. P10.0 is not backward-compatible with AV1 and cannot be played on non-Dolby licensed device while P10.1 and P10.4 can. The purpose of this piece of code is to return null for P10.0 and to return MimeTypes.VIDEO_AV1 for P10.1 and 10.4.

This method (getAlternativeCodecMimeType()) is called in both track selection and codec selection phase.

During track selection phase, the input is manifest file. CCID is not explicitly indicated in manifest file. The only method is to calculate it based on supplementalCodecs and supplementalProfiles (Since neither supplementalCodecs nor supplementalProfiles is the member of Format structure, we set ColorInfo at first then conclude the CCID based on it).

During codec selection phase, the input includes MPEG4 box info. CCID can be get directly by parsing Format::initializationData.

As a common method in both track selection and codec selection phase, we adopted the ColorInfo method in this PR.

I agree it is not a perfect solution. In future, maybe we need to update getColorInfoForFormat() method to adapt new Dolby Vision profile definitions.

@microkatz microkatz self-requested a review October 9, 2025 15:09
@microkatz microkatz self-assigned this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants