This repository was archived by the owner on Jan 10, 2019. It is now read-only.
add optional 4th param for Redis auth support#15
Open
mrtidy wants to merge 2 commits intoandyet:developfrom
Open
add optional 4th param for Redis auth support#15mrtidy wants to merge 2 commits intoandyet:developfrom
mrtidy wants to merge 2 commits intoandyet:developfrom
Conversation
Author
|
I just added a second commit to this request. The documentation in README.md is currently wrong. It left off the error parameter in the callback of feed.publish and has the order of the parameters for feed.retract backwards. current, incorrect docs:corrected docs:I renamed Thank you.
|
Author
|
Are there any doubts with this diff? I'm happy to adjust if necessary. |
Author
|
It would be helpful if you would merge in this pull. |
|
I also implemented authentication, but on master, I hadn't noticed your pull request before. It's a straightforward change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For this case, if I only provide Thoonk with hostname and port, then I get an error from RedisClient:
I verified that existing tests all still pass as well as possible but I haven't committed the modifications of the tests supporting passwords because of a node_redis issue ( redis/node-redis#155 ): test_jobs uses 'ready' and current versions of node_redis fail due to an auth issue.
Thank you.