Skip to content

Conversation

@novakboskov
Copy link

Reading the paper, I got the feeling that relative_hidden_states[layer] should be the difference between positive and negative function/concept templates. RepReadingPipeline.get_directions seemingly relies on train_inputs[::2] being the positive and train_inputs[1::2] the negative ones, but it does not ensure that. This may affect some downstream usages of RepReadingPipeline.get_directions.

For example, in honesty.ipynb, the training data gets prepared by honesty_function_dataset, which shuffles the labels of prompts:

train_labels = []
for d in train_data:
true_s = d[0]
random.shuffle(d)
train_labels.append([s == true_s for s in d])

When such prepared data is passed to RepReadingPipeline.get_directions, train_inputs[::2] are not necessarily the positive function/concept templates.

Am I reading this right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant